Copy the metadata map in Document.mutate() - #6913
Open
harrisleesh wants to merge 1 commit into
Open
Conversation
mutate() passed the document's internal metadata map into the new builder by reference, so builder metadata modifications altered the original document - contradicting the documented contract of allowing selective modification without altering the original. Fixes spring-projects#6910 Signed-off-by: seonghun lee <harrisleesh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Document.mutate()is documented as "allowing selective modification without altering the original", but it passes the document's internal metadata map to the new builder by reference.Builder.metadata(key, value)puts directly into that map, so mutating the builder silently mutates the original document's metadata.Changes
mutate()now seeds the builder with a copy of the metadata map.mutate().metadata(...). It fails onmainand passes with the fix; the fullspring-ai-commonsmodule test suite passes (237 tests).Fixes #6910