Skip to content

Record remoteAddress in unmapped mapper - #101

Open
evisong wants to merge 1 commit into
springernature:mainfrom
evisong:add_remoteAddress_to_unmapped_mapper
Open

Record remoteAddress in unmapped mapper#101
evisong wants to merge 1 commit into
springernature:mainfrom
evisong:add_remoteAddress_to_unmapped_mapper

Conversation

@evisong

@evisong evisong commented Sep 28, 2018

Copy link
Copy Markdown

Hi, team,

In my use case, remoteAddress helps a lot when analyzing beacons. It seems this argument is passed into map function but it's never used yet: https://github.com/springernature/boomcatch/blob/master/src/index.js#L656

I'm adding it to unmapped mapper.

Could you kindly let me know if it's proper to do so, and if yes whether should I add to other mappers as well?

Thanks.

@josebolos

Copy link
Copy Markdown
Contributor

Hi @evisong,

Thanks for your PRs! I'll try to have a look at them as soon as possible.

@evisong

evisong commented Jan 2, 2019

Copy link
Copy Markdown
Author

Hi @evisong,

Thanks for your PRs! I'll try to have a look at them as soon as possible.

Hi, @josebolos,

May I ask if there is any progress yet? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants