Skip to content

Test fixtures aren't not valid ansi sql #538

Description

@hfhbd

Dialect

SQLite

Failing SQL

SELECT 42 WHERE 1 = ?1;

Description

Unfortunately, there is no real ANSI sql standard, because the standard itself is not very strict and every vendor has custom dialects. But the test fixtures should be dialect agnostic as possible.

This includes:

  • No ?1 because this syntax isn't supported by all dialects (eg PostgreSQL R2DBC or DB2)
  • Always add a FROM clause. While almost all dialects do support omitting the FROM clause, DB2 does not.

One simple option split the test fixtures and the variable into ansi sql and common sql (name to be discussed), which contains the failing test fixtures.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions