Updated icons to use system icon theme, using symbolic icons where possible.

[newhoa]

I noticed in the Gtk3 issue thread you mentioned that the icons needed work. It made me curious so I just looked to see what could be changed.

I don't know if this is what you had in mind, but many icons were missing or using png icons included with gmusicbrowser itself. I updated most of the icon entries to instead use system theme icons. I changed most of the icons to adhere to the FreeDesktop.org Icon Naming Spec. Additionally, I went ahead and set them all as symbolic icons. Doing this makes the icons adapt to the user theme whether a light or dark theme is used. The menu icons highlight on mouseover and the Play/Pause/Stop icons can be more easily seen when the row is selected in the playlist. The trade-off is that it's all monochrome basically. I also removed as many references to the hardcoded/included gmusicbrowser icons in the pix folder (using system theme icons instead).

I made sure to use only icons that were included in the default desktop icon themes, and modern icon themes in general. I checked to make sure all icons were available under the default Gnome/XFCE icon theme (Adwaita), default KDE icon theme (Breeze), default MATE icon theme, and the Elementary icon theme which gmusicbrowser already included some icons of. I also checked to make sure they were working in all of the included Layouts.

I'll keep making adjustments as I continue to use it if I notice any that I missed. I tried to pick icons that were appropriate to the action. For example, the queue icon is actually a format-indent icon, but it looks like a list with a "play next" looking arrow icon in pretty much every theme. Maybe some of these could be better (or might require new custom icons which I can help with as well if needed), but for now I think it is more functional and complete and will work for everyone.

I don't know how to change some of them like the Rating icons and the Volume icons (they both seem to need code changes, and that's beyond what I know). I also couldn't figure out how to change the dialog button icons (Close, About, etc) but will look into it more later.

These were all basically just icon name changes/replacements. I did add ellipses to some of the menu entries that require further action. And I also added some icons to the right click menu entries, tabs (Year, Info, Lyrics, etc), and menus where some were missing. But I didn't change any functionality or any code beyond cosmetics.

I'm not sure if this is something you want (maybe the symbolic icons aren't colorful enough, or maybe you wanted the icon code reworked completely, etc). But I enjoyed doing it and just thought I'd throw it out there in case it helps.

Thanks for the amazing program!

[Denebet]

Good morning,

I just published a theme for gmusicbrowser at https://www.pling.com/p/2230712/. On the one hand, I encountered a small difficulty with an icon, on the other hand our work should complement each other, it seems to me. This is why, if you are still available and motivated, I suggest you contact me (systemelibre@free.fr) to consider a modest collaboration.