Skip to content

Improve dependency specification #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
RasmusSkytte wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Improve dependency specification #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9ba56d1
chore(DESCRIPTION): Move `withr` to Imports
Jun 19, 2026
497ee4a
fix(get_connection): Check `RSQLite` is installed for defaults
Jun 19, 2026
e8107d0
docs(NEWS): Add entry on withr dependency
Jun 19, 2026
2f0da2b
chore(DESCRIPTION): Remove base r packages
Jun 19, 2026
68c0c9f
chore(get_connection): Fix lints
RasmusSkytte Jul 8, 2026
9a7706f
chore: Update pak.lock
RasmusSkytte Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ Imports:
dplyr,
glue,
lubridate,
methods,
openssl,
parallelly,
purrr,
Expand All @@ -51,7 +50,7 @@ Imports:
stringr,
tidyr,
tidyselect,
utils
withr
Suggests:
callr,
conflicted,
Expand All @@ -73,8 +72,7 @@ Suggests:
spelling,
testthat (>= 3.0.0),
tibble,
tidyverse,
withr
tidyverse
Language: en-US
URL: https://github.com/ssi-dk/SCDB, https://ssi-dk.github.io/SCDB/
Config/testthat/edition: 3
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# SCDB (development version)

## Improvements and Fixes

* `withr` added as a dependency rather than a suggested package (#238).


# SCDB 0.6.2

Expand Down
5 changes: 4 additions & 1 deletion R/connection.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@
#' @export
get_connection <- function(drv, ...) {
if (missing(drv)) {
get_connection.SQLiteDriver(drv = RSQLite::SQLite(), ...)
if (!rlang::is_installed("RSQLite")) {
stop("No `drv` provided to `get_connection` and `RSQLite` is not installed to act as default.", call. = FALSE)
}
get_connection(drv = RSQLite::SQLite(), ...)
} else {
UseMethod("get_connection")
}
Expand Down
20 changes: 5 additions & 15 deletions pak.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@
},
{
"package": "duckdb",
"version": "1.5.4",
"version": "1.5.2",
"binary": true
},
{
Expand Down Expand Up @@ -616,7 +616,7 @@
},
{
"package": "shiny",
"version": "1.14.0",
"version": "1.13.0",
"binary": true
},
{
Expand Down Expand Up @@ -741,12 +741,12 @@
},
{
"package": "withr",
"version": "3.0.3",
"version": "3.0.2",
"binary": true
},
{
"package": "xfun",
"version": "0.59",
"version": "0.58",
"binary": true
},
{
Expand Down Expand Up @@ -779,15 +779,5 @@
"version": "3.0.0",
"binary": true
}
],
"sysreqs": {
"os": "linux",
"distribution": "ubuntu",
"version": "24.04",
"url": {},
"pre_install": "apt-get -y update",
"install_scripts": "apt-get -y install libx11-dev git libcurl4-openssl-dev libssl-dev xz-utils cmake make libuv1-dev libgit2-dev zlib1g-dev pandoc unixodbc-dev libfreetype6-dev libjpeg-dev libpng-dev libtiff-dev libwebp-dev libpq-dev libicu-dev libfontconfig1-dev libfribidi-dev libharfbuzz-dev libxml2-dev",
"post_install": {},
"packages": ["libx11-dev", "git", "libcurl4-openssl-dev", "libssl-dev", "xz-utils", "cmake", "make", "libuv1-dev", "libgit2-dev", "zlib1g-dev", "pandoc", "unixodbc-dev", "libfreetype6-dev", "libjpeg-dev", "libpng-dev", "libtiff-dev", "libwebp-dev", "libpq-dev", "libicu-dev", "libfontconfig1-dev", "libfribidi-dev", "libharfbuzz-dev", "libxml2-dev"]
}
]
}
Loading