fix(win): tree-kill local PTYs so ports free on terminal stop by innocarpe · Pull Request #10346 · stablyai/orca

innocarpe · 2026-07-24T08:49:20Z

Summary

On Windows, every local PTY stop runs taskkill /T /F on the ConPTY root before shell kill, so npm run dev / Vite children release listening ports.
Ports panel kill also tree-kills on Windows instead of single-PID process.kill.
POSIX keeps agent-only descendant snapshot kill; plain POSIX terminals still skip tree-kill so intentional nohup children survive.

Why

Closing a terminal (or switching projects) on Windows only stopped the shell process. Child servers reparented and kept the port, so Project B appeared to serve Project A’s site.

Relationship to #10004 / #10100

Shares the Windows taskkill /T helper and killWithDescendantSweep branch. This PR applies tree-kill to all local Windows PTYs (not only agent sessions) and the Ports kill path, which is what frees dev-server ports. #10100 can be closed as partially superseded once this lands, or restacked to keep agent-specific POSIX notes.

Test plan

windows-process-tree-kill, pty-descendant-termination (incl. Windows sweep), workspace-port-ownership, local-pty-provider tests
pnpm typecheck:node
Manual on Windows: npm run dev in a worktree terminal → close tab → confirm port free / Project B binds cleanly; Ports UI Stop also frees port

Note: Re-opened as a new PR after an accidental empty force-push during local rebase cleanup closed the original #10183 (no code intent to withdraw). Branch tip restored with an empty recovery commit.

ELI5

Closing a terminal on Windows left child processes (like npm/Vite) holding ports. Local PTY stop now tree-kills the process tree so ports free immediately.

innocarpe · 2026-07-24T08:54:06Z

Sync update (`4b3b450f5`)

Rebased onto latest upstream/main after recovery; resolved conflicts in local-pty-provider (Windows tree-kill for all local PTYs) and tests.

Commit: 4b3b450f5bf656bcfecc7bd7a9aecd5849f16352
Upstream: fix(win): tree-kill local PTYs so ports free on terminal stop #10346
Fork portfolio: [upstream #10183] fix(win): tree-kill local PTYs so ports free on terminal stop innocarpe/orca#39

coderabbitai · 2026-07-24T09:03:46Z

Warning

Review limit reached

@innocarpe, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 24 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: dd171cef-6bb7-4036-b138-de319d211e7e

📥 Commits

Reviewing files that changed from the base of the PR and between 7da9368 and e94e4a8.

📒 Files selected for processing (6)

src/main/ports/workspace-port-ownership.test.ts
src/main/ports/workspace-port-ownership.ts
src/main/providers/local-pty-provider.test.ts
src/main/providers/local-pty-provider.ts
src/main/pty-descendant-termination.test.ts
src/main/pty-descendant-termination.ts

📝 Walkthrough

Walkthrough

The change adds Windows workspace-port process-tree termination with retryable PID liveness checks and injectable delays. POSIX termination remains SIGTERM-based. PTY shutdown replaces descendant snapshots with asynchronous descendant sweeps and extends Windows cleanup to immediate shutdowns. Tests cover ownership checks, retry outcomes, shutdown coordination, and natural process exit. PTY launch handling removes default WSL and Windows environment fallbacks, simplifies session and PATH handling, and stops registering the startup echo probe.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description includes the summary and test plan but omits required AI Review Report, Security Audit, Screenshots, Notes, and most template test checks.	Add every template section, report AI cross-platform review and security findings, state "No visual change", and record all executed test commands or explain skipped checks.
Out of Scope Changes check	⚠️ Warning	The PR also changes WSL fallback, reattach IDs, attach-only spawning, PATH handling, and removes unrelated tests outside the linked issue objective.	Remove unrelated behavioral changes and test deletions, or link them to separate issues and split them into focused pull requests.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the Windows PTY tree-kill change that addresses port release.
Linked Issues check	✅ Passed	The changes implement Windows process-tree termination for local PTYs and port kills, with liveness retries to free ports as required by [`#10150`].
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 2

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 178c6a60-1c8c-4c5a-b610-fe2cf3cc7ed0

📥 Commits

Reviewing files that changed from the base of the PR and between 981653f and a5cce6f.

📒 Files selected for processing (8)

src/main/ports/workspace-port-ownership.test.ts
src/main/ports/workspace-port-ownership.ts
src/main/providers/local-pty-provider.test.ts
src/main/providers/local-pty-provider.ts
src/main/pty-descendant-termination.test.ts
src/main/pty-descendant-termination.ts
src/main/windows-process-tree-kill.test.ts
src/main/windows-process-tree-kill.ts

innocarpe · 2026-07-26T03:10:25Z

Sync update (`274473faa`)

Address CodeRabbit: retry Windows liveness probe after taskkill (PID may linger until handles drain); platform restore already in finally

Commit: 274473faac12ebc65ecc6a062cf55eb34bfbeabc
Upstream: fix(win): tree-kill local PTYs so ports free on terminal stop #10346
Fork portfolio: [upstream #10183] fix(win): tree-kill local PTYs so ports free on terminal stop innocarpe/orca#39

innocarpe · 2026-08-06T03:42:15Z

Sync update (`e8060f107e`)

Rebase onto latest upstream/main: Windows tree-kill for ports/PTYs; keep requireMetadata re-scan; identity-probe-safe tests.

Commit: e8060f107ee6a9f9a89024b1de3731874f92cedb
Upstream: fix(win): tree-kill local PTYs so ports free on terminal stop #10346
Fork portfolio: [upstream #10346] fix(win): tree-kill local PTYs so ports free on terminal stop innocarpe/orca#146

coderabbitai · 2026-08-06T03:42:18Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

coderabbitai

Actionable comments posted: 1

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 104cb2b8-f6f5-4f9a-b795-d5824ed83219

📥 Commits

Reviewing files that changed from the base of the PR and between ff01fad and e8060f1.

📒 Files selected for processing (6)

src/main/ports/workspace-port-ownership.test.ts
src/main/ports/workspace-port-ownership.ts
src/main/providers/local-pty-provider.test.ts
src/main/providers/local-pty-provider.ts
src/main/pty-descendant-termination.test.ts
src/main/pty-descendant-termination.ts

🚧 Files skipped from review as they are similar to previous changes (1)

src/main/pty-descendant-termination.test.ts

On Windows, ConPTY shell-only kill left npm/dev-server children listening, so switching projects could still serve the previous app on the same port. - taskkill /T /F via killWithDescendantSweep for every local PTY stop on Windows - Ports UI kill path also tree-kills on Windows - Keep POSIX agent-only descendant sweep; plain POSIX terminals unchanged Closes stablyai#10150 Related: overlaps Windows agent path of stablyai#10004 / stablyai#10100

terminateWindowsProcessTree is best-effort and always resolves so PTY teardown is never blocked. Ports UI needs a real outcome: after taskkill, probe liveness with process.kill(pid, 0) and return failure if the PID is still alive. Addresses CodeRabbit review on stablyai#10183.

EPERM from process.kill(pid, 0) means the process is still alive without signal rights; do not report Ports kill success in that case. Addresses CodeRabbit follow-up on stablyai#10183.

… rebase cleanup No code change. Re-opens the contribution for review after branch recovery.

… path

…ession tests Preserve WorkspacePortScanOptions on scanWorkspacePortProbes and re-add the authorizing re-scan metadata tests dropped during conflict resolution, while keeping Windows tree-kill liveness probes for stablyai#10150.

innocarpe · 2026-08-06T04:16:08Z

Sync update (`e94e4a8e8f`)

Sync update

Rebased onto latest upstream/main and resolved conflicts.

Kept focused Windows tree-kill for ports/PTY teardown ([Bug]: Port is not released after stopping/switching project, causing new project to route to previous site #10150) + post-taskkill liveness (ESRCH-only success)
Preserved upstream attachOnly / resolvePathEnvKey / requireMetadata scan options
Restored [Bug]: UI hangs when child-process creation is delayed by an injected endpoint-security module #11161 requireMetadata regression tests alongside Windows kill coverage
CodeRabbit PATH case-sensitivity note: already handled on main via resolvePathEnvKey; out of scope for this focused fix
Commit: e94e4a8e8ff6302e1a03c73dc8ea88522fb23816
Upstream: fix(win): tree-kill local PTYs so ports free on terminal stop #10346
Fork portfolio: [upstream #10346] fix(win): tree-kill local PTYs so ports free on terminal stop innocarpe/orca#146

innocarpe mentioned this pull request Jul 24, 2026

fix(win): tree-kill local PTYs so ports free on terminal stop #10183

Closed

3 tasks

innocarpe force-pushed the fix/windows-terminal-port-tree-kill branch from a5cce6f to 4b3b450 Compare July 24, 2026 08:53

innocarpe mentioned this pull request Jul 24, 2026

[upstream #10183] fix(win): tree-kill local PTYs so ports free on terminal stop innocarpe/orca#39

Closed

coderabbitai Bot reviewed Jul 24, 2026

View reviewed changes

Comment thread src/main/ports/workspace-port-ownership.test.ts

Comment thread src/main/ports/workspace-port-ownership.ts

AmethystLiang assigned OrcaWin Jul 24, 2026

AmethystLiang requested a review from OrcaWin July 24, 2026 16:49

innocarpe force-pushed the fix/windows-terminal-port-tree-kill branch from 4b3b450 to 8d56dd0 Compare July 25, 2026 10:34

nwparker added the bug Something isn't working label Jul 27, 2026

innocarpe force-pushed the fix/windows-terminal-port-tree-kill branch from 274473f to 1ad4b84 Compare July 27, 2026 15:24

innocarpe force-pushed the fix/windows-terminal-port-tree-kill branch from 1ad4b84 to e8060f1 Compare August 6, 2026 03:42

innocarpe mentioned this pull request Aug 6, 2026

[upstream #10346] fix(win): tree-kill local PTYs so ports free on terminal stop innocarpe/orca#146

Open

coderabbitai Bot reviewed Aug 6, 2026

View reviewed changes

Comment thread src/main/providers/local-pty-provider.ts Outdated

innocarpe added 6 commits August 6, 2026 13:14

fix(ports): treat only ESRCH as success after Windows tree-kill

4b92a3e

EPERM from process.kill(pid, 0) means the process is still alive without signal rights; do not report Ports kill success in that case. Addresses CodeRabbit follow-up on stablyai#10183.

chore: restore PR branch tip after accidental empty force-push during…

9a757c8

… rebase cleanup No code change. Re-opens the contribution for review after branch recovery.

test(win): mock tree-kill identity probe after rebase onto verify-own…

75d34d7

… path

innocarpe force-pushed the fix/windows-terminal-port-tree-kill branch from e8060f1 to e94e4a8 Compare August 6, 2026 04:16

Navigation Menu

Uh oh!

fix(win): tree-kill local PTYs so ports free on terminal stop - #10346

fix(win): tree-kill local PTYs so ports free on terminal stop#10346
innocarpe wants to merge 6 commits into
stablyai:mainfrom
innocarpe:fix/windows-terminal-port-tree-kill

innocarpe commented Jul 24, 2026 •

edited by nwparker

Loading

Uh oh!

innocarpe commented Jul 24, 2026

Uh oh!

coderabbitai Bot commented Jul 24, 2026 •

edited

Loading

Review limit reached

Walkthrough

❌ Failed checks (2 warnings)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

innocarpe commented Jul 26, 2026

Uh oh!

innocarpe commented Aug 6, 2026

Uh oh!

coderabbitai Bot commented Aug 6, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

innocarpe commented Aug 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

innocarpe commented Jul 24, 2026 • edited by nwparker Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Relationship to #10004 / #10100

Test plan

ELI5

Uh oh!

innocarpe commented Jul 24, 2026

Sync update (4b3b450f5)

Uh oh!

coderabbitai Bot commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

❌ Failed checks (2 warnings)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

innocarpe commented Jul 26, 2026

Sync update (274473faa)

Uh oh!

innocarpe commented Aug 6, 2026

Sync update (e8060f107e)

Uh oh!

coderabbitai Bot commented Aug 6, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

innocarpe commented Aug 6, 2026

Sync update (e94e4a8e8f)

Sync update

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

innocarpe commented Jul 24, 2026 •

edited by nwparker

Loading

Sync update (`4b3b450f5`)

coderabbitai Bot commented Jul 24, 2026 •

edited

Loading

Sync update (`274473faa`)

Sync update (`e8060f107e`)

Sync update (`e94e4a8e8f`)