Refactor to allow tool to be used with kayobe overcloud introspection data save#10
Open
jovial wants to merge 1 commit into
Open
Refactor to allow tool to be used with kayobe overcloud introspection data save#10jovial wants to merge 1 commit into
jovial wants to merge 1 commit into
Conversation
priteau
requested changes
Jun 23, 2020
| m2-gen --limit 4 -vv | ||
| m2-collect --limit 4 -vv | ||
|
|
||
| To extract the the introspection data and process it ready for cardiff input: |
|
|
||
| m2-extract introspection-data/*.json | ||
|
|
||
| This will have created the directores: ``extra-hardware``, ``extra-hardware-json`` |
| Dependencies | ||
| ============ | ||
|
|
||
| Requires the python `hardware <https://pypi.org/project/hardware/>`_ |
Member
There was a problem hiding this comment.
If that's purely for running hardware-cardiff, we should point out that it is only included up to version 0.24.0 of the hardware package.
priteau
requested changes
Jun 23, 2020
Comment on lines
+87
to
+89
| os.mkdir("extra-hardware") | ||
| os.mkdir("extra-hardware-filtered") | ||
| os.mkdir("extra-hardware-json") |
Member
There was a problem hiding this comment.
We should keep going if these already exist. Currently we fail with:
FileExistsError: [Errno 17] File exists: 'extra-hardware'
| with open(path, 'r') as f: | ||
| introspection_data = json.load(f) | ||
|
|
||
| extra_data = introspection_data["data"] |
Member
There was a problem hiding this comment.
Gracefully skip here, maybe with a warning, if the data key doesn't exist. This happens if the extra-hardware collector wasn't enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
m2-gentool has been split in two:m2-collect.m2-extractprocesses the dataOther changes:
has been modified to be consistent withkayobe overcloud introspection save`.extra_hardwaredata is now extracted from thedatafield in the introspection data. It is no longer collected separately from swift.