Let a manual dispatch actually deploy - #12
Merged
Merged
Conversation
The deploy step was gated on `github.event_name == 'push'`, so a workflow_dispatch ran install, lint, build and both verify steps and then skipped the single step it had been dispatched for. There was no way to redeploy main without inventing a commit. That turned a transient GitHub delay into a stuck deploy today: merging #11 produced no push event, and the push to dev that followed arrived about twenty minutes late. main was correct in git and stale on the live site, with no recovery path. Checked that the dispatch run really did skip the step rather than fail it, which is why nothing looked wrong. dev still stops at the checks either way — the ref_name condition is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deploy step was gated on
github.event_name == 'push', so aworkflow_dispatchran install, lint, build and both verify steps — and thenskipped the single step it had been dispatched for. There was no way to
redeploy
mainwithout inventing a commit.That turned a transient GitHub delay into a stuck deploy today:
gh api .../actions/runs?head_sha=<merge sha>returnedtotal_count: 0.devthat followed arrived roughly 20 minutes late.mainwas correct in git and stale on the live site, with the removedfiles still returning 200, and no recovery path.
devstill stops at the checks either way — theref_namecondition isunchanged, only the event condition widens.
Verification
Confirmed the dispatch run genuinely skipped the deploy step rather than
failing it, which is exactly why nothing looked wrong: