One switch per pending page; move CI off Node 20 - #14
Merged
Merged
Conversation
Projects and Resources are on the client's agreed page list, so they stay. Each was gated in two places — hidden in the nav, noindex in the SEO table — which could drift. Both now read their data file's own flag, as the gallery does. checkout, setup-node and upload-artifact go to v7, codeql-action to v4; all run on node24. Checked each tag's action.yml rather than assuming a major.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projects and Resources stay — with one switch each
Both are on the client's own agreed page list (Home, Projects, Services,
Process, Resources, About, Contact), so deleting them would override him. And
Resources holds the FAQ, which is exactly the answer-shaped content the SEO
plan recommends for AI search. They are pending content, not dead routes.
The actual fault was that each was gated in two places —
hidden: truein thenav,
noindex: truein the SEO table — which could drift apart. Each now readsits own data file's flag (
PROJECTS_ARE_PLACEHOLDER,RESOURCES_ARE_PROTOTYPE),the same single switch the gallery uses: flipping it reveals the nav entry,
drops the noindex and adds the sitemap entry together.
Tested the flip end to end: setting
PROJECTS_ARE_PLACEHOLDER = falseputs/projectsin the sitemap (5 → 6 entries) andverify:seostill passes.Node 20 deprecation
Checked each tag's
action.ymlforruns.usingrather than assuming — v7 isthe current major, not v5.
peaceiris/actions-gh-pages@v4was already node24.