Drop the wordmark text from the header and footer - #8
Merged
Merged
Conversation
The logo already carries the name, so setting it again in type beside the mark read as the brand stated twice. - Header: remove the KALAPRITI / DESIGNS text block. The name stays on the link's aria-label, which already carried it, so the home link is still announced. - Footer: remove the KALAPRITI / Designs heading. Nothing else in that column names the practice now, so the mark takes a real alt instead of being decorative. - Scale both marks up. The footer mark at 64px read as an orphaned icon in a column of its own; the header mark looked smaller standing alone than it did beside type. 48px there leaves the 89px header height unchanged, since that is driven by padding. Checked in the production build that the two dropped rules are gone from both bundles and that the 620px mark size is still scoped to its media query.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logo already carries the name, so setting it again in type beside the mark
read as the brand stated twice. Client asked for the mark alone in both places.
KALAPRITI / DESIGNStext block. The name stays on thelink's
aria-label, which already carried it, so the home link is stillannounced.
KALAPRITI / Designsheading. Nothing else in thatcolumn names the practice now, so the mark takes a real
altrather thanstaying decorative.
column of its own; the header mark looked smaller standing alone than it did
beside type. 48px there leaves the 89px header height unchanged, since that is
padding-driven.
Verification
npm run lintandnpm run buildclean.nav__brand-textandfooter__wordmarkare gone from both the minified CSSand the JS bundle.
.nav__markoverride is still scoped inside its media query — worthchecking explicitly, since LightningCSS has hoisted same-value rules out of
media queries in this stylesheet before.