Skip to content

chore(mariadb): sdk migration#1447

Open
j1n-o9r wants to merge 8 commits into
mainfrom
chore/STACKITCLI-368-SDK-migration-MariaDB
Open

chore(mariadb): sdk migration#1447
j1n-o9r wants to merge 8 commits into
mainfrom
chore/STACKITCLI-368-SDK-migration-MariaDB

Conversation

@j1n-o9r

@j1n-o9r j1n-o9r commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Description

relates to STACKITCLI-368

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions Bot added the Stale label Jul 2, 2026
@j1n-o9r j1n-o9r force-pushed the chore/STACKITCLI-368-SDK-migration-MariaDB branch from dc657f8 to bd899c4 Compare July 6, 2026 17:30
@j1n-o9r j1n-o9r removed the Stale label Jul 6, 2026
@j1n-o9r j1n-o9r marked this pull request as ready for review July 6, 2026 17:38
@j1n-o9r j1n-o9r requested a review from a team as a code owner July 6, 2026 17:38
@j1n-o9r j1n-o9r enabled auto-merge (squash) July 6, 2026 17:39
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/credentials/create 45.10% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/credentials/delete 37.50% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/credentials/describe 56.82% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/credentials/list 60.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/instance/create 62.22% (+0.68%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/instance/delete 26.83% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/instance/describe 60.42% (+8.33%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/instance/list 59.18% (+2.32%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/instance/update 58.06% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/plans 53.85% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/mariadb/client 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/mariadb/utils 26.67% (+1.67%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/credentials/create/create.go 45.10% (ø) 51 23 28
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/credentials/delete/delete.go 37.50% (ø) 40 15 25
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/credentials/describe/describe.go 56.82% (ø) 44 25 19
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/credentials/list/list.go 60.00% (ø) 50 30 20
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/instance/create/create.go 62.22% (+0.68%) 90 (-1) 56 34 (-1) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/instance/delete/delete.go 26.83% (ø) 41 11 30
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/instance/describe/describe.go 60.42% (+8.33%) 48 29 (+4) 19 (-4) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/instance/list/list.go 59.18% (+2.32%) 49 (-2) 29 20 (-2) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/instance/update/update.go 58.06% (ø) 93 54 39
github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/plans/plans.go 53.85% (ø) 52 28 24
github.com/stackitcloud/stackit-cli/internal/pkg/services/mariadb/client/client.go 0.00% (ø) 1 0 1
github.com/stackitcloud/stackit-cli/internal/pkg/services/mariadb/utils/utils.go 26.67% (+1.67%) 30 (-2) 8 22 (-2) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/credentials/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/credentials/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/credentials/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/credentials/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/instance/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/instance/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/instance/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/instance/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/instance/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/mariadb/plans/plans_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/mariadb/utils/utils_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant