feat: error on unrecognized fields in signer config - #7477
Open
brice-stacks wants to merge 4 commits into
Open
Conversation
Co-authored-by: Cyle Witruk <236413682+cylewitruk-stacks@users.noreply.github.com>
cylewitruk-stacks
previously approved these changes
Aug 3, 2026
Coverage Report for CI Build 30939477944Coverage decreased (-0.004%) to 86.614%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions108 previously-covered lines in 29 files lost coverage.
Coverage Stats
💛 - Coveralls |
cylewitruk-stacks
approved these changes
Aug 6, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 6, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 6, 2026
brice-stacks
commented
Aug 6, 2026
Contributor
Author
There was a problem hiding this comment.
When #7492 merges, change this to a .breaking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signer now refuses to start if its configuration file contains unrecognized fields, instead of silently ignoring them. This catches misspelled option names that previously would have slipped by without warning.