Skip to content

feat: error on unrecognized fields in signer config - #7477

Open
brice-stacks wants to merge 4 commits into
stacks-network:mainfrom
brice-stacks:signer-config-serde
Open

feat: error on unrecognized fields in signer config#7477
brice-stacks wants to merge 4 commits into
stacks-network:mainfrom
brice-stacks:signer-config-serde

Conversation

@brice-stacks

Copy link
Copy Markdown
Contributor

The signer now refuses to start if its configuration file contains unrecognized fields, instead of silently ignoring them. This catches misspelled option names that previously would have slipped by without warning.

Comment thread stacks-signer/src/config.rs Outdated
Co-authored-by: Cyle Witruk <236413682+cylewitruk-stacks@users.noreply.github.com>
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 30939477944

Coverage decreased (-0.004%) to 86.614%

Details

  • Coverage decreased (-0.004%) from the base build.
  • Patch coverage: 16 of 16 lines across 1 file are fully covered (100%).
  • 108 coverage regressions across 29 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

108 previously-covered lines in 29 files lost coverage.

Top 10 Files by Coverage Loss Lines Losing Coverage Coverage
stacks-node/src/neon_node.rs 13 83.14%
stackslib/src/net/download/nakamoto/tenure_downloader_unconfirmed.rs 9 74.13%
stackslib/src/net/server.rs 9 89.17%
stackslib/src/net/download/nakamoto/download_state_machine.rs 8 89.84%
stacks-node/src/nakamoto_node/miner.rs 8 87.12%
stacks-signer/src/v0/signer_state.rs 7 92.73%
clarity/src/vm/functions/bitcoin_madhouse.rs 6 82.57%
stackslib/src/net/stackerdb/config.rs 6 81.45%
stackslib/src/chainstate/stacks/index/marf.rs 5 84.07%
stacks-common/src/deps_common/bitcoin/network/encodable.rs 4 88.71%

Coverage Stats

Coverage Status
Relevant Lines: 232756
Covered Lines: 201599
Line Coverage: 86.61%
Coverage Strength: 19453472.27 hits per line

💛 - Coveralls

@hstove-stacks hstove-stacks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brice-stacks
brice-stacks added this pull request to the merge queue Aug 6, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 6, 2026
@brice-stacks
brice-stacks added this pull request to the merge queue Aug 6, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When #7492 merges, change this to a .breaking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants