Refactored ClarityBackingStorage trait to be more generic - #7480
Open
rob-stacks wants to merge 3 commits into
Open
Refactored ClarityBackingStorage trait to be more generic#7480rob-stacks wants to merge 3 commits into
rob-stacks wants to merge 3 commits into
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current ClarityBackingStorage trait is (still) heavily bound to sqlite. This patch makes it more generic without chnging the current logic (an additional abstraction layer for "Backing Stores" based on sqlite has been provided)
In addition to this it addresses the TrieHash/proof mechanism that right now is heavily tied to the MARF specific implementation (by allowing the proof to be invalid instead of empty)
Another patch will follow to take care of the MARF naming convention in some of the trait/structs
Note that an example/proof-of-concept/non-marf implementation (HashMapWritableStore) is provided too in tests
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/property-testing.md)changelog.d/README.md)rpc/openapi.yamlfor RPC endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo