Remove high-S signature handling from miners and signers - #7484
Open
benjamin-stacks wants to merge 3 commits into
Open
Remove high-S signature handling from miners and signers#7484benjamin-stacks wants to merge 3 commits into
benjamin-stacks wants to merge 3 commits into
Conversation
Follow-up to stacks-network#7163 and stacks-network#7337, where mempool admittance and block received special handling for those transactions. Now that we've transitioned into Epoch 4.0, those signatures are forbidden by consensus and no longer need to be special-cased.
Contributor
|
Looks like |
brice-stacks
reviewed
Aug 4, 2026
brice-stacks
left a comment
brice-stacks
left a comment
Contributor
There was a problem hiding this comment.
Looks good aside from the failing test that needs to be updated.
This comment explained the additional function argument that was removed in d6021f4, so it's no longer needed.
This section of the `mempool_setup_chainstate()` test was added in stacks-network#7163 to ensure that the mempool rejects high-S signatures. That was necessary back then because this behavior differed from consensus behavior. Now that high-S signatures are disallowed by consensus (this has test coverage elsewhere), it's no longer necessary to check this special case. And because this test does not run as Epoch 4.0, in this case the check actively fails.
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7163 and #7337, where mempool admittance and block validation received special handling for those transactions. Now that we've transitioned into Epoch 4.0, those signatures are forbidden by consensus and no longer need to be special-cased.