Feat: add option to disable contract interface fields - #7488
Open
aaronb-stacks wants to merge 1 commit into
Open
Feat: add option to disable contract interface fields#7488aaronb-stacks wants to merge 1 commit into
aaronb-stacks wants to merge 1 commit into
Conversation
Coverage Report for CI Build 31034481045Coverage increased (+0.03%) to 86.61%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions137 previously-covered lines in 36 files lost coverage.
Coverage Stats
💛 - Coveralls |
| pub local_peer_seed: Option<String>, | ||
| pub miner: Option<bool>, | ||
| pub stacker: Option<bool>, | ||
| pub disable_contract_interface_in_events: Option<bool>, |
Contributor
There was a problem hiding this comment.
Maybe we could put this beneath an [event_publisher] or similar stanza? My gut feeling is that we're probably going to end up with a handful of similar kinds of configurations moving forward...
Or, maybe even better would be to have this on a per-observer basis, since it's likely only necessary specifically for the explorer indexer.
Thoughts?
Contributor
There was a problem hiding this comment.
+1 for making this a per observer field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the option to drop the contract interface field from event dispatcher events for people running observers that are uninterested in those fields.