chore(chart): use example-registry placeholder in tests and CI - #596
Merged
Conversation
Signed-off-by: Zadkiel AHARONIAN <hello@zadkiel.fr>
aslafy-z
force-pushed
the
chore/example-registry-placeholder
branch
from
July 30, 2026 11:23
ff6eee9 to
12e0271
Compare
Signed-off-by: Zadkiel AHARONIAN <hello@zadkiel.fr>
aslafy-z
force-pushed
the
chore/example-registry-placeholder
branch
from
July 30, 2026 11:25
12e0271 to
9c15845
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Normalizes the placeholder image values used in tests and CI to the
example-*family:registry/example-imagebecomesexample-registry/example-imageinapplication/tests/cronjob_test.yaml,deployment_test.yaml,job_test.yaml(suite fixtures and per-test values/asserts),application/ci/values.yaml, and the--set deployment.image.repository=...install flag in.github/workflows/ci.yamlanother-example-*family: the image templating tests (uses image templatingcases in the three suites) useanother-example-registry/another-example-image/another-example-tag/another-example-digestinstead ofcustom-image/custom-tag/custom-digest, and the initContainers tests in the CronJob and Job suites useanother-example-registry/another-example-image:another-example-taginstead of the bareexample-image:example-tagapplication/tests/__snapshot__/common_test.yaml.snap: regenerated withhelm-unittest -urenovate.json:ignoreDepsupdated to cover theexample-registry/another-example-registryandexample-image/another-example-imagecombinationsWhy
registry/reads like a real path segment. Prefixing it withexample-makes every component of the placeholder reference (example-registry/example-image:example-tag) self-describing as arbitrary. The templating tests need values distinct from the suite fixture so the asserts prove the value flowed through{{ .Values.custom.image.* }}rather than the default; theanother-example-*family makes that distinction obvious at a glance while staying in the same example-style vocabulary, instead of the unrelatedcustom-*naming. It also gives future tests that need a second placeholder container (e.g. the sidecar tests in #593) an established convention.Notes
openshift/oauth-proxy:latestin the deployment tests is the chart's actual default, not a placeholder, and is intentionally left as is.Validation
helm-unittest application: 382 tests, 37 snapshots, all passingct lint: passing