fix: map unexpected reranking gateway error - #2530
Open
erichare wants to merge 3 commits into
Open
Conversation
Contributor
Unit Test Coverage Report
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
erichare
changed the title
erichare
marked this pull request as ready for review
August 5, 2026 19:11
Contributor
Author
|
@amorton i know this might be more of a workaround than a solution, so i understand if you just want to discard it and "do it right", and im happy to spend more time. But was wondering if you think doing something like this could be a temporary way to improve the situation, at least allowing us to more easily see the root nvidia error? Edit: my thought was we could at least perhaps deploy this to dev to help debug the underlying errors we're seeing more easily, but let me know what you think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes the reranking gateway failure:
No enum constant io.stargate.sgv2.jsonapi.exception.SchemaException.Code.UNEXPECTED_SERVER_ERRORRerankingEGWClientassumed every error code returned by Embedding Gateway was aSchemaException.Code. Embedding Gateway usesServerException.Code.UNEXPECTED_SERVER_ERRORfor non-API exception failures, so that enum lookup masked the original provider failure with anIllegalArgumentException.This change maps that known server code back to
ServerException, then leaves the existing schema-error path unchanged. It preserves the publicSERVER_UNEXPECTED_SERVER_ERRORidentity used by responses and metrics while retaining the original gateway error body.Validation:
git diff --checkpassedWhich issue(s) this PR fixes:
N/A — follow-up to the GPU-plane concurrency investigation.
Checklist