Prime reranking auth before parallel batches - #2531
Closed
erichare wants to merge 1 commit into
Closed
Conversation
Contributor
Unit Test Coverage Report
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
amorton
reviewed
Aug 6, 2026
amorton
left a comment
Contributor
There was a problem hiding this comment.
-1 blocking until we know more , at the surface level this does not feel like the best idea, we should fix the upstream problem
amorton
requested changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Runs reranking batch 0 to completion before constructing and subscribing to the remaining batches. A successful first batch primes the upstream API Gateway authorizer cache; the tail batches then retain their existing concurrent, fail-fast execution.
This reduces the authorization cache-miss fan-out of one multi-batch
findAndRerankrequest from as many as one miss per batch to one miss per request. Concurrent top-level requests can still race each other, so this is intentionally paired with the Lambda timeout and resilience changes in riptano/cloud-helm-charts#1095.The tradeoff is one reranking-batch round trip on the critical path before the concurrent tail starts.
Which issue(s) this PR fixes:
Companion to riptano/cloud-helm-charts#1095.
Validation:
JAVA_HOME=/Library/Java/JavaVirtualMachines/graalvm-21.jdk/Contents/Home ./mvnw -B -ntp -Dstyle.color=always clean test(3,424 tests)Checklist