Fix peerDependencies of flow-bin package - #52
Conversation
`SemVer` behaviour is different in case major version of package is 0 (it's considered to be a pre-release version) so `^0.39.0` only corresponds to '0.39.0', which limits you from using any newer version of `flow-bin`. Required version is changed to allow all newer version up to `1.0`
Fix peerDependencies of `flow-bin` package
Added `flow-bin` as devDependency in order to pass tests.
| should.equal(stringError, true); | ||
| should.equal(iterationError, true); | ||
| should.equal(stringError, true, 'Error with string type is not found.'); | ||
| should.equal(iterationError, true, 'Error with interaction is not found.'); |
| if (/string/.test(arg)) stringError = true; | ||
| if (/Required/.test(arg)) moduleError = true; | ||
| if (/iteration/.test(arg)) iterationError = true; | ||
| if (/must be an object/.test(arg)) iterationError = true; |
There was a problem hiding this comment.
Expected '{' and instead saw 'iterationError'.
|
@charliedowler Any thoughts about ^^^? |
|
|
||
| return through.obj(Flow, function () { | ||
| var end = () => { | ||
| const end = () => { |
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
|
|
||
| isFileSuitable(file).then(() => { | ||
| var hasPragma = hasJsxPragma(file.contents.toString()); | ||
| const hasPragma = hasJsxPragma(file.contents.toString()); |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| function Flow(file, enc, callback) { | ||
|
|
||
| var _continue = () => { | ||
| const _continue = () => { |
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| var defers = servers.map(function(_path) { | ||
| var deferred = Q.defer(); | ||
| const defers = servers.map(function (_path) { | ||
| const deferred = Q.defer(); |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| function killServers() { | ||
| var defers = servers.map(function(_path) { | ||
| var deferred = Q.defer(); | ||
| const defers = servers.map(function (_path) { |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| const stream = childProcess.spawn(getFlowBin(), args); | ||
|
|
||
| var dat = ""; | ||
| let dat = ''; |
There was a problem hiding this comment.
'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| ]; | ||
|
|
||
| var stream = childProcess.spawn(getFlowBin(), args); | ||
| const stream = childProcess.spawn(getFlowBin(), args); |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| })() : 'status'; | ||
|
|
||
| var args = [ | ||
| const args = [ |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| const opts = optsToArgs(options); | ||
|
|
||
| var command = opts.length || options.killFlow ? (() => { | ||
| const command = opts.length || options.killFlow ? (() => { |
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| const deferred = Q.defer(); | ||
|
|
||
| var opts = optsToArgs(options); | ||
| const opts = optsToArgs(options); |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
|
|
||
| function executeFlow(_path, options) { | ||
| var deferred = Q.defer(); | ||
| const deferred = Q.defer(); |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
|
|
||
| function optsToArgs(opts) { | ||
| var args = []; | ||
| const args = []; |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| var servers = []; | ||
| var passed = true; | ||
| const servers = []; | ||
| let passed = true; |
There was a problem hiding this comment.
'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| */ | ||
| var servers = []; | ||
| var passed = true; | ||
| const servers = []; |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| const logSymbols = require('log-symbols'); | ||
| const childProcess = require('child_process'); | ||
| //const chalk = require('chalk'); | ||
| const reporter = require('flow-reporter'); |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| var chalk = require('chalk'); | ||
| var reporter = require('flow-reporter'); | ||
| const Q = require('q'); | ||
| const fs = require('fs'); |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'require' is not defined.
| var childProcess = require('child_process'); | ||
| var chalk = require('chalk'); | ||
| var reporter = require('flow-reporter'); | ||
| const Q = require('q'); |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'require' is not defined.
| @@ -1,3 +1,4 @@ | |||
| declare module 'log-symbols' { | |||
| declare var success : string; | |||
| declare var warning : string; | |||
There was a problem hiding this comment.
Expected an assignment or function call and instead saw an expression.
Missing semicolon.
Unrecoverable syntax error. (60% scanned).
| @@ -1,4 +1,5 @@ | |||
| declare module "gulp-util" { | |||
| declare function beep(val:any, cb:any): void; | |||
There was a problem hiding this comment.
'function closure expressions' is only available in Mozilla JavaScript extensions (use moz option).
'val' is defined but never used.
Expected ')' to match '(' from line 2 and instead saw ':'.
Expected '}' to match '{' from line 1 and instead saw ':'.
Expected an assignment or function call and instead saw an expression.
Expected an identifier and instead saw ')'.
Expected an identifier and instead saw ','.
Expected an identifier and instead saw ';'.
Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function.
Label 'cb' on any statement.
Missing semicolon.
| declare module 'child_process' { | ||
| declare function execFile(command: string, args: string[], callback: any) : void; | ||
|
|
||
| declare type child_process$execFileCallback = (error: ?child_process$Error, stdout: Buffer, stderr: Buffer) => void; |
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'error' is defined but never used.
Expected ')' to match '{b}' from line 3 and instead saw ':'.
Expected '=>' and instead saw '?'.
Expected '}' to match '{' from line 1 and instead saw ':'.
Expected an assignment or function call and instead saw an expression.
Identifier 'child_process$Error' is not in camel case.
Identifier 'child_process$execFileCallback' is not in camel case.
Line is too long.
Missing semicolon.
Unrecoverable syntax error. (10% scanned).
2 participants
SemVerbehaviour is different in case major version of package is 0 (it's considered to be a pre-release version) so^0.39.0only corresponds to '0.39.0', which limits you from using any newer version offlow-bin. Required version is changed to allow all newer version up to1.0