Skip to content

Fix all security related issues, - #55

Open
ralic wants to merge 8 commits into
stcheng:masterfrom
SaferNodeJS:master
Open

Fix all security related issues, #55
ralic wants to merge 8 commits into
stcheng:masterfrom
SaferNodeJS:master

Conversation

@ralic

@ralic ralic commented Oct 25, 2019

Copy link
Copy Markdown
  1. Fix all current secuity report issues and add auto security fix postinstall in package.json (npm audit fix)
    Install the package by invoking 'npm install ', resolved security issues :
    Before
found 10 vulnerabilities (2 low, 6 moderate, 1 high, 1 critical)
  run `npm audit fix` to fix them, or `npm audit` for details

After

found 0 vulnerabilities
  1. Add eslint , using default google's style
  2. Upgrade node.js support to the latest (8~13)
  3. Remove or adjust dependencies to date.

Comment thread test/main.js
Comment thread test/main.js
Comment thread test/main.js
Comment thread test/main.js
Comment thread test/main.js
Comment thread test/main.js
Comment thread test/main.js
Comment thread test/main.js
Comment thread test/main.js
var stringError = false;
var moduleError = false;
var iterationError = false;
const log = console.log;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'console' is not defined.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

Comment thread test/main.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants