Skip to content

chore(deps): bump steadybit kits and drop Go patch pin - #490

Merged
joshiste merged 2 commits into
mainfrom
bump-go-1.26-floating
Aug 18, 2026
Merged

chore(deps): bump steadybit kits and drop Go patch pin#490
joshiste merged 2 commits into
mainfrom
bump-go-1.26-floating

Conversation

@joshiste

@joshiste joshiste commented Aug 17, 2026

Copy link
Copy Markdown
Member

Bumps the steadybit kit modules to versions declaring a floating go directive and removes the exact-patch pin (go 1.26.5) from this module.

What the go directive ends up as: go mod tidy normalises the directive to the minimum required by the module graph, so this lands on go 1.26.0 (not a bare go 1.26). That is still floating — any 1.26.x toolchain satisfies >= 1.26.0 — the exact-patch pin is what's removed.

Toolchain selection is handled separately: the go_version override is dropped from ci.yml so the reusable extension CI default ('1.26') applies, and setup-go installs the latest 1.26.x. This matches the floating golang:1.26-* Docker base images.

Note: go-version-file: go.mod was deliberately not used — since the directive normalises to a full version, it would pin CI to the oldest patch.

@joshiste
joshiste enabled auto-merge (squash) August 17, 2026 10:33
@claude

claude Bot commented Aug 17, 2026

Copy link
Copy Markdown

Claude finished @joshiste's task in 1m 1s —— View job


Claude's review of PR #490

  • Check previously unresolved review threads for fixes
  • Review new changes (diff vs origin/main)
  • Post summary

Previous review threads: Both of my earlier comments (on go.mod:3 and .github/workflows/ci.yml:62) are already resolved. The author's replies clarify the go.mod directive can't float below 1.26.0 due to a dependency's go directive, and floating is instead handled via check-latest: true in CI. The e2e-tests job (.github/workflows/ci.yml:41) was fixed to use go-version: '1.26' with check-latest: true, matching the extension-ci reusable workflow default — so both jobs now resolve to the same floating toolchain selection. No further action needed there.

New changes in this diff (origin/main...HEAD):

  • .github/workflows/ci.yml: e2e-tests setup-go step now uses go-version: '1.26' + check-latest: true instead of the hardcoded ^1.26.5; the go_version override was dropped from the extension-ci call so it inherits the reusable workflow's default. Consistent and addresses the prior gap.
  • go.mod / go.sum: mechanical bump of steadybit/action-kit, steadybit/discovery-kit, steadybit/extension-kit, and their transitive deps, plus the go directive change (1.26.51.26.0, already discussed above). Nothing unusual — version bumps only, no code logic touched.

No new bugs, security issues, or concurrency concerns found — this PR only touches dependency versions and CI toolchain configuration, no application code changed.

@joshiste
joshiste force-pushed the bump-go-1.26-floating branch from 69be121 to 3455bb5 Compare August 17, 2026 13:14
Comment thread go.mod
Comment thread .github/workflows/ci.yml
@joshiste joshiste changed the title chore(deps): use go-version-file, drop patch pin (go 1.26) chore(deps): bump steadybit kits and drop Go patch pin Aug 17, 2026
Bumps the kit modules to versions declaring a floating go directive and
removes the exact-patch pin. go mod tidy normalises the directive to the
module graph minimum (1.26.0), which is still floating - any 1.26.x
satisfies it. Also drops the redundant go_version override from ci.yml
so the reusable CI default ('1.26') applies.
@joshiste
joshiste force-pushed the bump-go-1.26-floating branch from 3455bb5 to b454fdc Compare August 18, 2026 09:54
The e2e-tests job had its own setup-go hardcoding '^1.26.5', which was
missed when the go_version override was dropped from the extension-ci
job. That left the two jobs able to build with different toolchains.
Uses '1.26' with check-latest, matching the reusable CI default.
@sonarqubecloud

Copy link
Copy Markdown

@joshiste
joshiste merged commit e801ba2 into main Aug 18, 2026
20 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant