Upgrade @stellar/stellar-xdr-json to v28 - #2188
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
There was a problem hiding this comment.
Pull request overview
Upgrades XDR JSON to v28 and supports both legacy type_ and new type event fields.
Changes:
- Updates dependency and event fixtures for v28.
- Adds backward-compatibility handling and unit tests.
- Includes unrelated network-limit and dependency-lock refreshes.
Reviewed changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Upgrades XDR JSON to v28. |
| pnpm-lock.yaml | Updates dependency resolutions. |
| src/types/types.ts | Supports both event type keys. |
| src/helpers/getTxResourceBreakdown.ts | Reads either event type key. |
| src/helpers/formatDiagnosticEvents.ts | Normalizes event type access. |
| src/constants/networkLimits.ts | Refreshes generated network data. |
| src/app/(sidebar)/transaction/dashboard/components/errorTestData.ts | Migrates diagnostic fixtures. |
| tests/unit/getTxResourceBreakdown.test.ts | Tests v27/v28 compatibility. |
| tests/unit/formatDiagnosticEvents.test.ts | Tests diagnostic formatting compatibility. |
| tests/unit/mock/txResponse.ts | Migrates transaction fixtures. |
| tests/e2e/mock/txEvents.ts | Migrates event fixtures. |
| tests/e2e/mock/txDash.ts | Migrates dashboard fixtures. |
| tests/e2e/mock/txCallStackTrace.ts | Migrates call-stack fixtures. |
| tests/e2e/mock/classicOperations.ts | Migrates classic-operation fixtures. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Preview is available here: |
|
Preview is available here: |
No description provided.