Skip to content

Upgrade @stellar/stellar-xdr-json to v28 - #2188

Open
quietbits wants to merge 3 commits into
mainfrom
xdr-json-v28
Open

Upgrade @stellar/stellar-xdr-json to v28#2188
quietbits wants to merge 3 commits into
mainfrom
xdr-json-v28

Conversation

@quietbits

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI balanced review requested due to automatic review settings August 25, 2026 20:19
@github-project-automation github-project-automation Bot moved this to Backlog (Not Ready) in DevX Aug 25, 2026
@socket-security

socket-security Bot commented Aug 25, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​stellar/​stellar-xdr-json@​28.0.0781008092100

View full report

@socket-security

socket-security Bot commented Aug 25, 2026

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades XDR JSON to v28 and supports both legacy type_ and new type event fields.

Changes:

  • Updates dependency and event fixtures for v28.
  • Adds backward-compatibility handling and unit tests.
  • Includes unrelated network-limit and dependency-lock refreshes.

Reviewed changes

Copilot reviewed 13 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json Upgrades XDR JSON to v28.
pnpm-lock.yaml Updates dependency resolutions.
src/types/types.ts Supports both event type keys.
src/helpers/getTxResourceBreakdown.ts Reads either event type key.
src/helpers/formatDiagnosticEvents.ts Normalizes event type access.
src/constants/networkLimits.ts Refreshes generated network data.
src/app/(sidebar)/transaction/dashboard/components/errorTestData.ts Migrates diagnostic fixtures.
tests/unit/getTxResourceBreakdown.test.ts Tests v27/v28 compatibility.
tests/unit/formatDiagnosticEvents.test.ts Tests diagnostic formatting compatibility.
tests/unit/mock/txResponse.ts Migrates transaction fixtures.
tests/e2e/mock/txEvents.ts Migrates event fixtures.
tests/e2e/mock/txDash.ts Migrates dashboard fixtures.
tests/e2e/mock/txCallStackTrace.ts Migrates call-stack fixtures.
tests/e2e/mock/classicOperations.ts Migrates classic-operation fixtures.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pnpm-lock.yaml Outdated
Comment thread src/constants/networkLimits.ts
@stellar-jenkins-ci

Copy link
Copy Markdown

@stellar-jenkins-ci

Copy link
Copy Markdown

@quietbits
quietbits requested a review from jeesunikim August 25, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog (Not Ready)

Development

Successfully merging this pull request may close these issues.

4 participants