Fix home domain assignment for synthetic tier 1 creation - #430
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates synthetic tier-1 home domains so relaxed automatic quorum configuration treats each organization separately.
Changes:
- Replaces dotted synthetic domains with distinct hyphenated names.
- Prevents domain parsing from grouping all synthetic tier-1 nodes together.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bboston7
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now there is a suboptimal interaction between
--tier-1-orgs-to-addand--enable-relaxed-auto-qset-config. Because of how we extract the relevant part of a domain by picking a component split by.s, all added tier1s current'y end up with a parsed home domain ofdomain, putting them all in the same organization.