Give MaxTPSClassic its own resource sizing for one pod per node - #431
Open
Jonathan-Eid wants to merge 1 commit into
Open
Give MaxTPSClassic its own resource sizing for one pod per node#431Jonathan-Eid wants to merge 1 commit into
Jonathan-Eid wants to merge 1 commit into
Conversation
Jonathan-Eid
force-pushed
the
jonathan/maxtps-classic-resources
branch
from
August 21, 2026 14:57
4e6f60f to
12a834e
Compare
Splits MaxTPSClassic off SimulatePubnetTier1PerfResources into a new MaxTPSClassicResources case, requesting 1100m/2560Mi instead of 500m/128Mi. Limits are unchanged at 4 cpu / 6000Mi. The cpu request is what enforces one core pod per node; kubelet maxPods cannot, because it is a first-come-first-served admission cap that races the node's DaemonSets. The memory request stops the kubelet electing these pods as its first eviction victims under node pressure. The five other missions on SimulatePubnetTier1PerfResources are untouched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Jonathan-Eid
force-pushed
the
jonathan/maxtps-classic-resources
branch
from
August 21, 2026 15:00
12a834e to
0266f33
Compare
Jonathan-Eid
marked this pull request as ready for review
August 21, 2026 18:37
Contributor
There was a problem hiding this comment.
Pull request overview
Adds dedicated resource sizing for MaxTPSClassic workloads.
Changes:
- Adds a MaxTPSClassic resource profile.
- Applies it to the MaxTPSClassic mission.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
StellarMissionContext.fs |
Adds the resource-profile case. |
StellarKubeSpecs.fs |
Defines and maps resource requests and limits. |
MissionMaxTPSClassic.fs |
Selects the new profile. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bboston7
reviewed
Aug 21, 2026
bboston7
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Changes the cpu and memory requests of the MaxTPSClassicMission so a 2vCPU/8GB node can fit exactly one stellar-core pod
Issue
None filed.
🤖 Generated with Claude Code