Update styling.md for CSS custom properties clarification - #1612
Open
gunayanil wants to merge 1 commit into
Open
Update styling.md for CSS custom properties clarification#1612gunayanil wants to merge 1 commit into
gunayanil wants to merge 1 commit into
Conversation
The current note can make it sound like a custom property has to be declared on :host before consumers can set it. This clarifies that :host provides a component default, while consumers can set the property on the host element without that declaration.
|
@gunayanil is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the current note is a bit confusing/misleading if I understand it correctly. It indicates that a CSS custom property must first be declared on
:hostto be exposed to the consuming application, but I don't think this is the case.For example, this works without declaring the CSS custom property on
:host:Even
color: var(--heading-color);should work fine too.Then in consumer:
Here,
shadow-cardis the host element, and the CSS custom property inherits into the shadow tree without first being declared on:host.