closes #1 fix compilation on Mac#2
Merged
Merged
Conversation
Collaborator
Author
|
@nmnobre Andy suggested I get you to review as you have a Mac :-) |
nmnobre
requested changes
Jul 8, 2026
nmnobre
left a comment
nmnobre
left a comment
Member
There was a problem hiding this comment.
Andy suggested I get you to review as you have a Mac :-)
Well, I do... but it's an old, x86 Mac, unlike your screamer :-P If after these suggestions, it all still works on your end, I'm happy.
Co-authored-by: Nuno Nobre <nuno.nobre@stfc.ac.uk>
Member
|
Does it all still compile on your Mac? |
Collaborator
Author
|
@nmnobre this compiles on my Mac and the benchmark runs correctly, thank you! |
nmnobre
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.