⚡ Bolt: Optimize squared Euclidean norms via np.einsum - #174
Conversation
💡 What: Replaced occurrences of `(X ** 2).sum(axis)` with `np.einsum` equivalents (e.g. `np.einsum('ij,ij->i', X, X)`) in `snapvec/_kmeans.py`, `snapvec/_ivfpq.py`, and `snapvec/_pq.py`.
🎯 Why: `(X ** 2)` allocates a large intermediate NumPy array equal to the size of `X`, slowing down computation and consuming more memory.
📊 Impact: `einsum` avoids allocating this intermediate array, typically resulting in a ~2-3x execution speedup for these specific lines based on benchmarks.
🔬 Measurement: Verified with local timing benchmark scripts processing large arrays (e.g., `100_000 x 384` shape inputs or multi-dimensional codebook tensors), showing consistent 2x+ speedups against the original code. Runs `pytest` suite without regressions.
Co-authored-by: stffns <70039235+stffns@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Warning Review limit reached
Next review available in: 39 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughSquared L2 norm and distance calculations in k-means, PQ, and IVFPQ implementations now use ChangesSquared L2 math optimization
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What: Replaced occurrences of `(X ** 2).sum(axis)` with `np.einsum` equivalents (e.g. `np.einsum('ij,ij->i', X, X)`) in `snapvec/_kmeans.py`, `snapvec/_ivfpq.py`, and `snapvec/_pq.py`.
🎯 Why: `(X ** 2)` allocates a large intermediate NumPy array equal to the size of `X`, slowing down computation and consuming more memory.
📊 Impact: `einsum` avoids allocating this intermediate array, typically resulting in a ~2-3x execution speedup for these specific lines based on benchmarks.
🔬 Measurement: Verified with local timing benchmark scripts processing large arrays (e.g., `100_000 x 384` shape inputs or multi-dimensional codebook tensors), showing consistent 2x+ speedups against the original code. Runs `pytest` suite without regressions.
Co-authored-by: stffns <70039235+stffns@users.noreply.github.com>
💡 What: Replaced occurrences of `(X ** 2).sum(axis)` with `np.einsum` equivalents (e.g. `np.einsum('ij,ij->i', X, X)`) in `snapvec/_kmeans.py`, `snapvec/_ivfpq.py`, and `snapvec/_pq.py`.
🎯 Why: `(X ** 2)` allocates a large intermediate NumPy array equal to the size of `X`, slowing down computation and consuming more memory.
📊 Impact: `einsum` avoids allocating this intermediate array, typically resulting in a ~2-3x execution speedup for these specific lines based on benchmarks.
🔬 Measurement: Verified with local timing benchmark scripts processing large arrays (e.g., `100_000 x 384` shape inputs or multi-dimensional codebook tensors), showing consistent 2x+ speedups against the original code. Runs `pytest` suite without regressions.
Co-authored-by: stffns <70039235+stffns@users.noreply.github.com>
💡 What:
Replaced occurrences of
(X ** 2).sum(axis)withnp.einsumequivalents (e.g.np.einsum('ij,ij->i', X, X)) insnapvec/_kmeans.py,snapvec/_ivfpq.py, andsnapvec/_pq.py.🎯 Why:
The expression
(X ** 2)forces NumPy to allocate a large intermediate array equal in size toX. In highly repetitive or batch loops, this intermediate allocation slows down execution and causes unnecessary garbage collection and memory spikes.np.einsumavoids this intermediate allocation entirely by directly accumulating the element-wise squares into the final result.📊 Impact:
einsumavoids allocating the intermediate array, resulting in a ~2-3x execution speedup for the targeted operations (especially beneficial during k-means training and distance matrix calculations for high-dimensional arrays and codebook tensors).🔬 Measurement:
Benchmarked locally by timing
((X - c) ** 2).sum(1)againstnp.einsum('ij,ij->i', diff, diff)on a dataset of shape(100_000, 384)yielding an ~8-15% end-to-end reduction for that block and up to 3x raw speedups for simpler(X ** 2).sum(1)forms. Verified functional correctness by successfully passing all tests viapython -m pytest tests/ -v, static typing viamypy --strict snapvec/, and formatting viaruff check snapvec/.PR created automatically by Jules for task 4031158093442841632 started by @stffns
Summary by CodeRabbit