Conversation
Contributor
|
I like that this change, but I don't like that this will create a merge conflict in approximately every open pull request. Could we delay this a bit? Also, I'll vote for |
Contributor
Author
|
Sure, we can definitely delay. Not sure whether we can find a timeframe with no open PRs, but I agree that too many open PRs are conflicting at the moment. I like the idea of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somewhat related to #1033
New folder
storm/numberscontains functionality for numbers:constants.handConstantsComparator.hKwekMehlhornandRationalApproximationNumberTraitsrationalfunction.hAlso use a new namespace
storm::numbersinstead ofstorm::utility.This required a lot of replacements of e.g.
storm::utility::one<..>tostorm::numbers::one<..>but I think this gives a nicer structure in the future.