Skip to content

Moved number classes/functions to storm/numbers - #1041

Open
volkm wants to merge 3 commits into
stormchecker:masterfrom
volkm:numbers
Open

volkm wants to merge 3 commits into
stormchecker:masterfrom
volkm:numbers

Conversation

@volkm

@volkm volkm commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Somewhat related to #1033

New folder storm/numbers contains functionality for numbers:

  • constants.h and ConstantsComparator.h
  • KwekMehlhorn and RationalApproximation
  • NumberTraits
  • rationalfunction.h

Also use a new namespace storm::numbers instead of storm::utility.
This required a lot of replacements of e.g. storm::utility::one<..> to storm::numbers::one<..> but I think this gives a nicer structure in the future.

@tquatmann

Copy link
Copy Markdown
Contributor

I like that this change, but I don't like that this will create a merge conflict in approximately every open pull request. Could we delay this a bit?

Also, I'll vote for storm::numbers::convert instead of storm::numbers::convertNumber.

@volkm

volkm commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Sure, we can definitely delay. Not sure whether we can find a timeframe with no open PRs, but I agree that too many open PRs are conflicting at the moment.

I like the idea of numbers::convert, will change it.

@volkm volkm added the delay merge PR touching a lot of files. Delay merge a bit because it will lead to conflicts with other PR. label Sep 7, 2026
@volkm volkm mentioned this pull request Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delay merge PR touching a lot of files. Delay merge a bit because it will lead to conflicts with other PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants