Preserve slices when setting an indexed value - #170
Merged
Merged
Conversation
hanzei
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set("names[0]", "Mat")replaces the entirenamesslice with"Mat". The existing test misses the data loss becauseGet("names[0]")also ignores an index on a non-slice and returns that scalar.For indexed writes into
[]interface{}, traverse the indices and update the final element instead of assigning the map key. Return a missing value when a read attempts to index a non-slice. Regression tests check that other elements survive, nested writes work, nil can be assigned, and out-of-range writes preserve the slice. Both new tests fail before the fix.Checklist
go test -race ./...with coverage enabled (99.1%).gofmt -d -s *.goandgo vet ./...commands; both are clean.Validated with Go 1.27.1.