perf(ir): flatten a sequence whose only meta is outputs - #83
Merged
Conversation
An anonymous `set(...)` lowers to a sequence carrying just the outputs its members declared, which `flatten` refused to inline (`!child.meta`), leaving a pointless nested struct in generated code. Inline it and hoist the outputs onto the parent, which is now their scope. Guard the merge: refuse when it would collide two same-named bindings, or re-resolve a hoisted output ref to a different binding. The frontend dedupes sibling names per scope long before this pass, so it never sees the merged namespace - a collision silently dropped a parameter (already possible for a meta-less child on main, now fixed too).
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An anonymous
set(...)lowers to a sequence carrying only the outputs its members declared, whichflattenrefused to inline, leaving a pointless nested struct in generated code (betshipped aBetStruct1the caller had to build). Inline it and hoist the outputs onto the parent, which is now their scope.The merge is guarded: it is refused when it would collide two same-named bindings, or re-resolve a hoisted output's ref to a different binding. The frontend dedupes sibling names per scope long before this pass runs, so it never sees the merged namespace.
Generated Python for all 1919 NiWrap descriptors is byte-identical to
main.