fix: flag and enum fidelity in argdump and Boutiques - #90
Merged
Conversation
… members by count
This was referenced Aug 28, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #88. Partially addresses #86, #87 and #89: the naming and grouping problems are fixed, the union arm type is not (see the issue threads).
Also fixes an unreported miscompile. A bool whose IR arms are two literals (
-hypo 1/-hypo 0) was emitted as a single-token BoutiquesFlag, dropping the value from the command line. Live on three freesurfer inputs;corpus-roundtripcannot catch this class because it only asserts re-parse succeeds.Breaking: argdump mutex group ids now derive from member names rather than argparse dests (
fs_subjects_dir_or_run_reconall->fs_subjects_dir_or_fs_no_reconall).