feat(ui): add <C-p>/<C-n> history navigation to question dialog input - #483
Merged
Merged
Conversation
Problem: the 'Type your own answer' inline input box did not inherit any input history, so users could not scroll back through prior answers the way `vim.fn.input()` allows with `<C-p>`/`<C-n>`. Solution: bind insert-mode `<C-p>`/`<C-n>` in `inline_input.lua` that walk vim's built-in `input` history via `vim.fn.histget`/`histadd`, sharing the same history list as `vim.fn.input()` itself.
Owner
|
Thanks for the PR. This is a great addition |
jugarpeupv
pushed a commit
to jugarpeupv/opencode.nvim
that referenced
this pull request
Aug 22, 2026
…sudo-tee#483) Problem: the 'Type your own answer' inline input box did not inherit any input history, so users could not scroll back through prior answers the way `vim.fn.input()` allows with `<C-p>`/`<C-n>`. Solution: bind insert-mode `<C-p>`/`<C-n>` in `inline_input.lua` that walk vim's built-in `input` history via `vim.fn.histget`/`histadd`, sharing the same history list as `vim.fn.input()` itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: the 'Type your own answer' inline input box did not inherit
any input history, so users could not scroll back through prior answers
the way
vim.fn.input()allows with<C-p>/<C-n>.Solution: bind insert-mode
<C-p>/<C-n>ininline_input.luathatwalk vim's built-in
inputhistory viavim.fn.histget/histadd,sharing the same history list as
vim.fn.input()itself.