432 bug services - #248
Merged
Merged
432 bug services#248
Conversation
framework.file_type was set twice in config/services.php — the second ->set() call for BelgiumPostCodeType silently overwrote FileType's registration, dropping its sumoFile form.type tag/alias. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the service configuration to register BelgiumPostCodeType under its own service ID, preventing it from overwriting FileType and preserving both form type registrations and aliases. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
The duplicate framework.file_type service id was fixed in this branch; the workaround note in docs/forms.md no longer applies. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
tijsverkoyen
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AC: https://app.activecollab.com/108877/projects/533/tasks/259192
fix: register BelgiumPostCodeType under its own service id
framework.file_type was set twice in config/services.php — the second ->set() call for BelgiumPostCodeType silently overwrote FileType's registration, dropping its sumoFile form.type tag/alias. BelgiumPostCodeType now gets its own service id (framework.belgium_post_code_type).
Summary by Sourcery
Fix the form service registrations so FileType and BelgiumPostCodeType are both available under distinct service IDs.
Bug Fixes:
Documentation: