Skip to content

432 bug services - #248

Merged
jonasdekeukelaere merged 2 commits into
masterfrom
432-bug-services
Sep 15, 2026
Merged

jonasdekeukelaere merged 2 commits into
masterfrom
432-bug-services

Conversation

@jonasdekeukelaere

@jonasdekeukelaere jonasdekeukelaere commented Sep 15, 2026

Copy link
Copy Markdown
Member

AC: https://app.activecollab.com/108877/projects/533/tasks/259192

fix: register BelgiumPostCodeType under its own service id

framework.file_type was set twice in config/services.php — the second ->set() call for BelgiumPostCodeType silently overwrote FileType's registration, dropping its sumoFile form.type tag/alias. BelgiumPostCodeType now gets its own service id (framework.belgium_post_code_type).

Summary by Sourcery

Fix the form service registrations so FileType and BelgiumPostCodeType are both available under distinct service IDs.

Bug Fixes:

  • Register BelgiumPostCodeType under a dedicated service ID so FileType retains its form type registration and alias.

Documentation:

  • Remove the documentation describing the duplicate service ID as a known bug.

framework.file_type was set twice in config/services.php — the second
->set() call for BelgiumPostCodeType silently overwrote FileType's
registration, dropping its sumoFile form.type tag/alias.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@sourcery-ai

sourcery-ai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the service configuration to register BelgiumPostCodeType under its own service ID, preventing it from overwriting FileType and preserving both form type registrations and aliases.

File-Level Changes

Change Details Files
Give BelgiumPostCodeType a distinct service identifier so both form types remain registered independently.
  • Rename the service key from framework.file_type to framework.belgium_post_code_type.
  • Preserve the sumoBelgiumPostCode form.type alias while avoiding overwriting FileType’s sumoFile registration.
config/services.php

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

The duplicate framework.file_type service id was fixed in this branch;
the workaround note in docs/forms.md no longer applies.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@jonasdekeukelaere
jonasdekeukelaere merged commit df7544f into master Sep 15, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants