Fix loading new blogpost with new tags - #450
Merged
Merged
Conversation
Save the tag with correct module name
Reviewer's guide (collapsed on small PRs)Reviewer's GuideFixes new blog post tag loading by storing tags under the correct Blog module identifier and prevents interface checks from failing when a class has no implemented interfaces. Sequence diagram for saving tags on a new blog postsequenceDiagram
participant BlogModel
participant BackendTagsModel
BlogModel->>BackendTagsModel: saveTags(item[id], tags, Blog)
BackendTagsModel-->>BlogModel: Tags stored under Blog module
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
tijsverkoyen
approved these changes
Sep 1, 2026
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. The casing change alters the module identifier used when saving blog post tags, so a mistake could write tag associations under the wrong namespace and leave incorrect persisted records after reverting. Those associations should be bounded and repairable by cleaning up or recomputing them; the defensive class_implements fallback only changes error handling for unsupported classes.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save the tag with correct module name
Summary by Sourcery
Correct blog post tag persistence and make tag interface detection robust for classes without implemented interfaces.
Bug Fixes: