Skip to content

Fix loading new blogpost with new tags - #450

Merged
absumo merged 1 commit into
masterfrom
fix-blogpost-tag
Sep 1, 2026
Merged

absumo merged 1 commit into
masterfrom
fix-blogpost-tag

Conversation

@absumo

@absumo absumo commented Sep 1, 2026

Copy link
Copy Markdown

Save the tag with correct module name

Summary by Sourcery

Correct blog post tag persistence and make tag interface detection robust for classes without implemented interfaces.

Bug Fixes:

  • Fix saving tags for newly loaded blog posts by using the correct Blog module name.
  • Prevent tag interface checks from failing when a class does not implement any interfaces.

Save the tag with correct module name
@absumo
absumo requested a review from tijsverkoyen September 1, 2026 09:23
@sourcery-ai

sourcery-ai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Fixes new blog post tag loading by storing tags under the correct Blog module identifier and prevents interface checks from failing when a class has no implemented interfaces.

Sequence diagram for saving tags on a new blog post

sequenceDiagram
    participant BlogModel
    participant BackendTagsModel
    BlogModel->>BackendTagsModel: saveTags(item[id], tags, Blog)
    BackendTagsModel-->>BlogModel: Tags stored under Blog module
Loading

File-Level Changes

Change Details Files
Use the canonical Blog module name when persisting tags for newly inserted posts.
  • Change the module identifier passed to tag persistence from lowercase to the expected capitalized form.
src/Backend/Modules/Blog/Engine/Model.php
Make tag interface discovery resilient when the target class implements no interfaces.
  • Default class_implements results to an empty array before checking for TagsInterface.
src/Frontend/Modules/Tags/Engine/Model.php

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Needs a human reviewer. The casing change alters the module identifier used when saving blog post tags, so a mistake could write tag associations under the wrong namespace and leave incorrect persisted records after reverting. Those associations should be bounded and repairable by cleaning up or recomputing them; the defensive class_implements fallback only changes error handling for unsupported classes.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@absumo
absumo merged commit e2b0182 into master Sep 1, 2026
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants