fix: java 8 compatibility for readAllBytes and build on pull requests - #61
Merged
Conversation
InputStream.readAllBytes is a Java 9+ API but the project targets Java 8, which broke the CI build jar. Replace it with a Java 8 compatible helper w.util.IOUtils.readAllBytes in ChangeResultTransformer, OuterWatchTransformer and WCompiler. Also trigger the build workflow on pull_request (release job still only runs on push/workflow_dispatch) so jar build failures are caught before merge, and update the change result no-match test to the surfaced "No methods match" message. Agent: opencode Model: deepseek/deepseek-v4-flash
JDK 8 javac names an inner nested lambda lambda$null$N (no enclosing source-method context), while JDK 17 uses lambda$<method>$N, which broke two OuterWatchTest assertions on the CI JDK 8 build. Count all collected lambda methods and accept any readable [lambda$N] outerDisplay. Agent: opencode Model: deepseek/deepseek-v4-flash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InputStream.readAllBytes is a Java 9+ API but the project targets Java 8, which broke the CI build jar. Replace it with a Java 8 compatible helper w.util.IOUtils.readAllBytes in ChangeResultTransformer, OuterWatchTransformer and WCompiler. Also trigger the build workflow on pull_request (release job still only runs on push/workflow_dispatch) so jar build failures are caught before merge, and update the change result no-match test to the surfaced "No methods match" message.
Agent: opencode
Model: deepseek/deepseek-v4-flash