fix(ci): docs.rs build was using incorrect flag - #651
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain.
Pull request overview
Corrects the docs.rs configuration, removes the unnecessary serde pin, and updates the crate to version 0.2.3.
Changes:
- Replaces
rustc-argswithrustdoc-args. - Removes the exact serde dependency pin.
- Updates the lockfile and package metadata.
File summaries
| File | Description |
|---|---|
supabase-wrappers/Cargo.toml |
Updates version, metadata, and docs.rs arguments. |
Cargo.lock |
Synchronizes package version and dependencies. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
imor
force-pushed
the
rs/fix-docs-rs-build
branch
from
September 15, 2026 05:47
577b52b to
57bdd5b
Compare
imor
added this pull request to stack #652
September 15, 2026 05:47
utkarash2991
approved these changes
Sep 15, 2026
imor
force-pushed
the
rs/fix-docs-rs-build
branch
from
September 15, 2026 09:28
57bdd5b to
9a0fa25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last PR misdiagnosed the problem being due to serde version. The actual problem was setting
rustc-args = ["--cfg", "docsrs"]instead of the correctrustdoc-args = ["--cfg", "docsrs"]. This PR reverts the serde version pinnned from that last PR, but keeps the refactoring to extractpublish-to-crates-io.ymlbecause that's genrally useful. Confirmed by manually publishing crate version0.2.2whose docs.rs build succeeded. This PR makes that fix permanent.