Use additional_linker_inputs in order to be compatible to Bazel 9 - #12
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Bazel/module configuration so the MKL static libraries link correctly under Bazel 9 / newer rules_cc, avoiding --whole-archive behavior that can introduce undefined-symbol link failures.
Changes:
- Bump
rules_ccdependency version to0.2.18. - Update the MKL
cc_libraryto useadditional_linker_inputs(and removealwayslink/ direct archive deps) to prevent unintended--whole-archivelinking under Bazel 9. - Add detailed inline documentation explaining the MKL static-linking rationale and failure mode.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| MODULE.bazel | Updates the rules_cc version for Bazel 9 compatibility. |
| extensions/mkl.BUILD | Adjusts MKL linking inputs/flags to avoid --whole-archive and documents the rationale. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
reimerix
approved these changes
Jun 11, 2026
armallen
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapted to make the
mkllibs compatible to newer versions of Bazel 9/rules_cc