Skip to content

fix: prod build failure caused by legacy-peer-deps when prune - #453

Merged
petruki merged 1 commit into
masterfrom
staging
Aug 29, 2026
Merged

fix: prod build failure caused by legacy-peer-deps when prune#453
petruki merged 1 commit into
masterfrom
staging

Conversation

@petruki

@petruki petruki commented Aug 29, 2026

Copy link
Copy Markdown
Member

This pull request introduces improvements to the build process, updates dependencies, and refactors how the Markdown module is provided in the Angular documentation module. The most important changes are grouped below:

Build process improvements:

  • Updated the build steps in .github/workflows/master.yml to include a production build (npm run build:prod) and to prune development dependencies with legacy peer dependency support (npm prune --omit=dev --legacy-peer-deps).
  • Modified the Dockerfile to use npm prune --omit=dev --legacy-peer-deps for consistency with the workflow, ensuring compatibility with legacy peer dependencies during the Docker build.

Dependency updates:

  • Upgraded the base Nginx image in the Dockerfile from nginx:1.31.3-alpine-slim to nginx:1.31.4-alpine-slim for security and stability improvements.

Angular module refactoring:

  • Refactored DocumentationModuleModule in documentation.module.ts to use the new provideMarkdown API for providing the Markdown module, replacing the previous MarkdownModule.forRoot and MarkdownModule.forChild usage.

@petruki petruki added this to the v2.2.1 milestone Aug 29, 2026
@petruki petruki self-assigned this Aug 29, 2026
@petruki petruki added the bug Something isn't working label Aug 29, 2026
@petruki
petruki merged commit 389180e into master Aug 29, 2026
3 checks passed
@petruki
petruki deleted the staging branch August 29, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant