Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the build process, updates dependencies, and refactors how the Markdown module is provided in the Angular documentation module. The most important changes are grouped below:
Build process improvements:
.github/workflows/master.ymlto include a production build (npm run build:prod) and to prune development dependencies with legacy peer dependency support (npm prune --omit=dev --legacy-peer-deps).Dockerfileto usenpm prune --omit=dev --legacy-peer-depsfor consistency with the workflow, ensuring compatibility with legacy peer dependencies during the Docker build.Dependency updates:
Dockerfilefromnginx:1.31.3-alpine-slimtonginx:1.31.4-alpine-slimfor security and stability improvements.Angular module refactoring:
DocumentationModuleModuleindocumentation.module.tsto use the newprovideMarkdownAPI for providing the Markdown module, replacing the previousMarkdownModule.forRootandMarkdownModule.forChildusage.