Skip to content

Fix missing hook arguments of in-flight requests - #151

Merged
daun merged 6 commits into
mainfrom
fix/in-flight-page-args
Sep 5, 2026
Merged

Fix missing hook arguments of in-flight requests#151
daun merged 6 commits into
mainfrom
fix/in-flight-page-args

Conversation

@daun

@daun daun commented Sep 4, 2026

Copy link
Copy Markdown
Member

Description

  • Visits served from an in-flight preload (hover a link, click before the fetch finishes) never populate args.page
    • Always set args.page and args.cache when reusing an in-flight preload
  • Also: a fetch exception during preload makes thing worse and ends in a full browser reload
    • Use a fresh fetch when the reused preload failed to make sure the visit completes normally
  • Changelog and version bump included :)

Checks

  • The PR is submitted to the main branch
  • The code was linted before pushing (npm run lint)
  • All tests are passing (npm run test)
  • New or updated tests are included
  • The documentation was updated as required

@daun
daun requested a review from a team September 4, 2026 09:14
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

Playwright test results

passed  108 passed
skipped  4 skipped

Details

stats  112 tests across 9 suites
duration  
commit  a7fcfce

Skipped tests

chromium → preload-plugin.spec.ts → active links → preloads links on touchstart
firefox → preload-plugin.spec.ts → active links → preloads links on touchstart
webkit → preload-plugin.spec.ts → active links → preloads links on touchstart
ios → preload-plugin.spec.ts → active links → preloads links on hover

@daun
daun merged commit 0205e11 into main Sep 5, 2026
2 checks passed
@daun
daun deleted the fix/in-flight-page-args branch September 5, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants