fix(release): locate tarballs under dist/ after artifact download - #46
Merged
Conversation
upload-artifact preserves the uploaded path, so the tarball lands at release-assets/release-<suffix>/dist/release-tarball-<suffix>/*.tar.gz. The lookup missed that layer and created v0.1.5 with 0 binaries. Check that nested path first, fail closed on 0 or incomplete sets.
Replace sequential stat loop with Promise.all per target and drop explanatory comments. Behavior identical, verified with deno check + lint. Part of tarball-path fix for #46.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.1.5shipped with 0 binaries. Publish loggedcreated GitHub release v0.1.5 with 0 binary tarball(s)and succeeded, so the release looked green.platform.ymluploadsdist/release-tarball-<suffix>/comment-checker-<target>.tar.gz.download-artifactpreserves that prefix insiderelease-assets/release-<suffix>/.create-github-release.tslooked forrelease-assets/release-<suffix>/comment-checker-*.tar.gzand never found a file. The same structure is now asserted locally.The five tarballs from run
32640073590are back-filled tov0.1.5in this branch's verification. Future releases fail closed instead of publishing an empty release.