fix(release): publish raw binaries on release, wire devshell hook - #48
Merged
Conversation
Tarballs contain a single file; downloading the binary directly is more convenient. Resolve tarballs concurrently, unpack each to release-assets/binaries/comment-checker-<target>[.exe] with Promise.all, and attach the binaries to the GitHub release instead of the archives.
flake.nix now fetches the v0.1.5 binaries from GitHub releases per system (SRI pinned) and wraps the binary with bwrap --unshare-net, --die-with-parent, ro-bind /nix/store /etc /usr (/lib,/lib64 probed). devShell exposes the wrapped `comment-checker` so `nix develop` is the install. .claude/settings.json wires PostToolUse Write|Edit|MultiEdit to that binary. Verified: `nix build .#comment-checker` and `nix develop -c comment-checker` flags `# increment counter` (exit 2) and passes a clean file (exit 0) inside the sandbox.
direnv exec . now provides the bubblewrapped v0.1.5 binary without manual nix develop. hook in .claude/settings.json resolves.
systemfsoftware-maker
force-pushed
the
fix/release-tarball-path
branch
from
August 23, 2026 16:47
831f8dc to
22a13d9
Compare
systemfsoftware-maker
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unpacks release tarballs concurrently to attach standalone binary assets to GitHub releases, and adds devshell hook dogfooding with fallback.
create-github-release.tsnow unpacks downloaded platform tarballs in parallel viatar -xzfand attaches the target-named executable binaries (comment-checker-<target>[.exe]) directly to the GitHub release alongside the release notes..claude/settings.jsonPostToolUse hook configuration forWrite|Edit|MultiEditthat checks for ambientcomment-checkerand falls back todirenv execin Nix environments.flake.nixand.envrcto build and linkcomment-checkerinto the local devshell for dogfooding.Validation
cargo fmt --check && cargo clippy --all-targets -- -D warnings && cargo test --all-targets(92 passed across 7 suites).