Skip to content

Fix GC-MS Fiehn RI Console compatibility - #779

Merged
YukiMatsuzawa merged 1 commit into
masterfrom
fix/gcms-fiehn-reference-matching-diagnostics
Sep 2, 2026
Merged

Fix GC-MS Fiehn RI Console compatibility#779
YukiMatsuzawa merged 1 commit into
masterfrom
fix/gcms-fiehn-reference-matching-diagnostics

Conversation

@htsugawa

Copy link
Copy Markdown
Contributor

Summary

  • accept colon and equals syntax, quoted values, and GUI/legacy GC-MS field aliases
  • resolve GC-MS library and RI dictionary paths relative to the method/mapping files
  • preserve path casing while parsing enum values case-insensitively
  • fail early with actionable MSP and RI dictionary diagnostics
  • report loaded GC-MS library and retention matching settings

Validation

  • dotnet test tests/MSDIAL5/MsdialCoreTestAppTests/MsdialCoreTestAppTests.csproj -c Release
  • Passed: 9, Failed: 0
  • Release Console build completed successfully
  • existing dependency and architecture warnings remain unchanged

@YukiMatsuzawa
YukiMatsuzawa merged commit 7238c2e into master Sep 2, 2026
9 checks passed
@YukiMatsuzawa
YukiMatsuzawa deleted the fix/gcms-fiehn-reference-matching-diagnostics branch September 2, 2026 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants