feat: add optional const API for Go loader via goconst - #169
Open
Kybxd wants to merge 1 commit into
Open
Conversation
Generate read-only Foo_Const views on Data()/Get*/Find* when const=true so mutation is a compile error, while leaving the default API unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
const=trueoption toprotoc-gen-go-tableau-loaderthat exposes goconst read-onlyFoo_Constviews throughData()/Get*/Find*, so accidental mutation is a compile error.Data()still returns*Foo).Message()remains the mutable escape hatch;MutableCheckstill applies to it.protoc-gen-go-conston the same protos.Test plan
python3 make.py test --lang go(default non-const generation)const=trueplusprotoc-gen-go-constin a localbuf.gen.yamland confirmData()/Get*/Find*returnFoo_Constand mutation does not compile