fix: resolve proto imports and Excel cleanup - #447
Open
wenchy wants to merge 3 commits into
Open
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #447 +/- ##
==========================================
- Coverage 75.63% 75.61% -0.03%
==========================================
Files 88 88
Lines 9531 9609 +78
==========================================
+ Hits 7209 7266 +57
- Misses 1747 1760 +13
- Partials 575 583 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
wenchy
changed the title
Kybxd
reviewed
Aug 17, 2026
Comment on lines
+110
to
+112
| // protoFilesMap selects the compilation entry points. Their imports | ||
| // must still be resolved from the configured proto paths, even when | ||
| // an imported dependency is not matched by protoFiles. |
Collaborator
There was a problem hiding this comment.
This is designed deliberately to prevent predefined protos from importing generated protos. Do not remove.
Kybxd
force-pushed
the
fix/overlapping-proto-roots
branch
from
August 17, 2026 12:12
45c69f8 to
9549989
Compare
Kybxd
force-pushed
the
fix/overlapping-proto-roots
branch
from
August 17, 2026 12:17
9549989 to
d35a994
Compare
Kybxd
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan