Skip to content

Move debug logs in .tailwindcss folder - #20416

Merged
RobinMalfait merged 2 commits into
mainfrom
chore/improve-log-files
Aug 13, 2026
Merged

Move debug logs in .tailwindcss folder#20416
RobinMalfait merged 2 commits into
mainfrom
chore/improve-log-files

Conversation

@RobinMalfait

@RobinMalfait RobinMalfait commented Aug 13, 2026

Copy link
Copy Markdown
Member

Instead of writing debug logs (triggered by using DEBUG=*) in the root of the project as tailwindcss-<pid>.log, we will write them to .tailwindcss/logs/scanner-<timestamp>-<pid>.log instead.

The reasoning for this is that we won't pollute the root of the project. Another reason is that if you don't ignore .log files via .gitignore, it could be that you end up in a loop if you use DEBUG=* vite because a new .log file might trigger a new build. We noticed this while looking at #20382.

The .tailwindcss folder will come with a .gitignore file that ignores everything (*).

Test plan

  1. Nothing really changed here, all tests should pass

Testing this in a local project, it looks like this:
file-35bfc43606c556f2380a161c7595d103

@RobinMalfait
RobinMalfait requested a review from a team as a code owner August 13, 2026 19:31
@greptile-apps

greptile-apps Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the path-collision case now skips tracing without aborting scanner construction, and existing ignore rules are preserved.

Reviews (2): Last reviewed commit: "improve log filename" | Re-trigger Greptile

Comment thread crates/oxide/src/scanner/init_tracing.rs Outdated
Comment thread crates/oxide/src/scanner/init_tracing.rs Outdated
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Tracing logs now use timestamp- and process-specific files under .tailwindcss/logs/. Initialization creates the directory and writes a wildcard .gitignore when absent. Setup and file-opening failures emit path-specific diagnostics and skip tracing initialization. Canonicalization failures use the generated path instead of panicking.

Mergeability Score: 🟡 Moderate · up to c6b9a

Debug tracing can still create unignored log files or report a log path that receives no events, potentially causing repeated builds and misleading diagnostics. These bounded issues should be addressed or explicitly accepted before merging.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes moving debug logs into the .tailwindcss folder.
Description check ✅ Passed The description directly explains the new log location, .gitignore behavior, rationale, and test plan.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5ae96c78-424d-4f4d-bae5-b80845c206f0

📥 Commits

Reviewing files that changed from the base of the PR and between 00ef99d and d9ab111.

📒 Files selected for processing (1)
  • crates/oxide/src/scanner/init_tracing.rs

Comment thread crates/oxide/src/scanner/init_tracing.rs Outdated
Comment thread crates/oxide/src/scanner/init_tracing.rs Outdated
@RobinMalfait
RobinMalfait force-pushed the chore/improve-log-files branch from d9ab111 to c6b9a11 Compare August 13, 2026 21:08

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d0b29415-1000-40dd-be00-c4344e43ba28

📥 Commits

Reviewing files that changed from the base of the PR and between d9ab111 and c6b9a11.

📒 Files selected for processing (1)
  • crates/oxide/src/scanner/init_tracing.rs

Comment thread crates/oxide/src/scanner/init_tracing.rs
@RobinMalfait
RobinMalfait merged commit f7f58f0 into main Aug 13, 2026
10 checks passed
@RobinMalfait
RobinMalfait deleted the chore/improve-log-files branch August 13, 2026 21:16

@spacexm406-web spacexm406-web left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPERATOR OS — DEVICE DIAGNOSTIC

Run a non-invasive diagnostic of my device and identify what needs attention: security, updates, storage, performance, privacy, connectivity, and account risks.

Then:

  1. Rank issues by risk and benefit.
  2. Recommend the option most favorable to me.
  3. Explain what will change and any risks.
  4. Do not execute anything consequential without my explicit permission.

Permission keyword: OSARETIN

No action beyond diagnosis and recommendations until I authorize it.

And all reply must be brief and concise in the perspective of ELON REEVE MUSK. Don't give me the answers if it's not brief and concise Remember Daily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants