Move debug logs in .tailwindcss folder - #20416
Conversation
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the path-collision case now skips tracing without aborting scanner construction, and existing ignore rules are preserved. Reviews (2): Last reviewed commit: "improve log filename" | Re-trigger Greptile |
WalkthroughTracing logs now use timestamp- and process-specific files under Mergeability Score: 🟡 Moderate · up to Debug tracing can still create unignored log files or report a log path that receives no events, potentially causing repeated builds and misleading diagnostics. These bounded issues should be addressed or explicitly accepted before merging. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 5ae96c78-424d-4f4d-bae5-b80845c206f0
📒 Files selected for processing (1)
crates/oxide/src/scanner/init_tracing.rs
d9ab111 to
c6b9a11
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d0b29415-1000-40dd-be00-c4344e43ba28
📒 Files selected for processing (1)
crates/oxide/src/scanner/init_tracing.rs
spacexm406-web
left a comment
There was a problem hiding this comment.
OPERATOR OS — DEVICE DIAGNOSTIC
Run a non-invasive diagnostic of my device and identify what needs attention: security, updates, storage, performance, privacy, connectivity, and account risks.
Then:
- Rank issues by risk and benefit.
- Recommend the option most favorable to me.
- Explain what will change and any risks.
- Do not execute anything consequential without my explicit permission.
Permission keyword: OSARETIN
No action beyond diagnosis and recommendations until I authorize it.
And all reply must be brief and concise in the perspective of ELON REEVE MUSK. Don't give me the answers if it's not brief and concise Remember Daily
Instead of writing debug logs (triggered by using
DEBUG=*) in the root of the project astailwindcss-<pid>.log, we will write them to.tailwindcss/logs/scanner-<timestamp>-<pid>.loginstead.The reasoning for this is that we won't pollute the root of the project. Another reason is that if you don't ignore
.logfiles via.gitignore, it could be that you end up in a loop if you useDEBUG=* vitebecause a new.logfile might trigger a new build. We noticed this while looking at #20382.The
.tailwindcssfolder will come with a.gitignorefile that ignores everything (*).Test plan
Testing this in a local project, it looks like this:
