Skip to content

Cold start performance improvements #20427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smnbbrv wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

Cold start performance improvements #20427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/tailwindcss/src/design-system.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ export function buildDesignSystem(
let variants = createVariants(theme)

let parsedVariants = new DefaultMap((variant) => parseVariant(variant, designSystem))
let cachedVariantOrder: Map<Variant, number> | null = null
let cachedVariantOrderSize = -1
let parsedCandidates = new DefaultMap((candidate) =>
Array.from(parseCandidate(candidate, designSystem)),
)
Expand Down Expand Up @@ -188,6 +190,11 @@ export function buildDesignSystem(
},

getVariantOrder() {
// parsedVariants only grows, so the cache should be reset only when the size changes
if (cachedVariantOrder !== null && cachedVariantOrderSize === parsedVariants.size) {
return cachedVariantOrder
}

let variants = Array.from(parsedVariants.values())
variants.sort((a, z) => this.variants.compare(a, z))

Expand All @@ -209,6 +216,9 @@ export function buildDesignSystem(
prevVariant = variant
}

cachedVariantOrder = order
cachedVariantOrderSize = parsedVariants.size

return order
},

Expand Down