Skip to content

refactor(markdown): move template settings from export dialog to settings panel - #747

Merged
tangcent merged 1 commit into
masterfrom
refactor/simplify-markdown-options-panel
Jul 31, 2026
Merged

refactor(markdown): move template settings from export dialog to settings panel#747
tangcent merged 1 commit into
masterfrom
refactor/simplify-markdown-options-panel

Conversation

@tangcent

@tangcent tangcent commented Jul 30, 2026

Copy link
Copy Markdown
Owner

Move the template file, URL, inline editor, copy-default-template button, and language selector from the Markdown export dialog to the persistent Markdown settings tab. These are configuration preferences that users set once, not per-export choices, so they belong in Settings rather than cluttering the export action panel.

The export dialog now only shows Output Directory and File Name — the per-export essentials.

@github-actions github-actions Bot added the type: enhancement New feature or request label Jul 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📦 Plugin has been packaged for this PR. You can download easy-api-3.1.8.252.0.zip from the GitHub Actions workflow run by clicking on the "Artifacts" dropdown.

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 58.09524% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.713%. Comparing base (886f7f7) to head (5f95b38).

Files with missing lines Patch % Lines
.../easyapi/channel/markdown/MarkdownSettingsPanel.kt 53.846% 35 Missing and 7 partials ⚠️
...ngcent/easyapi/channel/markdown/MarkdownChannel.kt 80.000% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##            master      #747       +/-   ##
=============================================
- Coverage   66.759%   66.713%   -0.046%     
=============================================
  Files          427       429        +2     
  Lines        24184     24208       +24     
  Branches      5908      5916        +8     
=============================================
+ Hits         16145     16150        +5     
- Misses        5800      5810       +10     
- Partials      2239      2248        +9     
Flag Coverage Δ
unittests 66.713% <58.095%> (-0.046%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...gcent/easyapi/channel/markdown/MarkdownSettings.kt 100.000% <100.000%> (ø)
...ngcent/easyapi/channel/markdown/MarkdownChannel.kt 72.727% <80.000%> (+3.456%) ⬆️
.../easyapi/channel/markdown/MarkdownSettingsPanel.kt 53.846% <53.846%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 886f7f7...5f95b38. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tangcent
tangcent force-pushed the refactor/simplify-markdown-options-panel branch from 5bd39f7 to d542fb0 Compare July 30, 2026 13:41
@github-actions

Copy link
Copy Markdown
Contributor

📦 Plugin has been packaged for this PR. You can download easy-api-3.1.8.252.0.zip from the GitHub Actions workflow run by clicking on the "Artifacts" dropdown.

@tangcent tangcent changed the title refactor(markdown): simplify MarkdownOptionsPanel by removing runtime-hard template fields refactor(markdown): move template fields from MarkdownOptionsPanel to MarkdownSettingsPanel Jul 30, 2026
@tangcent tangcent changed the title refactor(markdown): move template fields from MarkdownOptionsPanel to MarkdownSettingsPanel refactor(markdown): move template settings from export dialog to settings panel Jul 30, 2026
…ings panel

Move the template file, URL, inline editor, copy-default-template button, and
language selector from the Markdown export dialog to the persistent Markdown
settings tab. These are configuration preferences that users set once, not
per-export choices, so they belong in Settings rather than cluttering the
export action panel.

The export dialog now only shows Output Directory and File Name — the
per-export essentials.
@tangcent
tangcent force-pushed the refactor/simplify-markdown-options-panel branch from d542fb0 to 5f95b38 Compare July 30, 2026 14:07
@github-actions

Copy link
Copy Markdown
Contributor

📦 Plugin has been packaged for this PR. You can download easy-api-3.1.8.252.0.zip from the GitHub Actions workflow run by clicking on the "Artifacts" dropdown.

@tangcent
tangcent merged commit 018c827 into master Jul 31, 2026
12 checks passed
@tangcent
tangcent deleted the refactor/simplify-markdown-options-panel branch July 31, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant