refactor(sandbox)!: retire terminal proxy seam (0.45.0) - #353
Merged
Conversation
Remove the deprecated same-origin connection, runtime relay, WebSocket upgrade, and HMAC token exports after the fleet migrated to the browser-direct scoped-token route. Keep the generic workspace sandbox manager in its own module and regenerate the API docs. BREAKING CHANGE: removes the deprecated terminal proxy exports from @tangle-network/agent-app/sandbox; use createSandboxTerminalConnectionRoute. Closes #350
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebSocket upgrade relay, HMAC proxy-token module, supporting helpers, and
their tests. The browser-direct
createSandboxTerminalConnectionRouteis nowthe package's only terminal transport.
createWorkspaceSandboxManagerand its companion types by movingthem into
workspace-sandbox-manager.ts; the./sandboxsubpath itself andevery direct-transport export remain intact.
agent-docsoutputs. The generated
./sandboxsurface drops from 150 to 119 exports, andno removed proxy symbol remains in
src,tests, generated docs, or thebuilt declarations.
0.44.60to0.45.0. This is a breakingremoval of published exports; on a pre-1.0 package, consumers on
^0.44.60will not pick up0.45.xautomatically.Closes #350. Completes the final cleanup tracked by #343.
Zero-importer audit
All four migration gates are closed:
I queried GitHub's org-wide code search once per deprecated export, excluding
this repository:
gh api -X GET search/code \ -f q="$symbol org:tangle-network -repo:tangle-network/agent-app" \ -f per_page=100These 24 exports returned
total_count: 0outside agent-app:The remaining seven names returned text matches, but none is an importer. I
fetched every hit from its repository's current default branch with the
GitHub Contents API to classify it:
createWorkspaceSandboxConnectionHandlercreateSandboxTerminalConnectionRoute.createWorkspaceSandboxRuntimeProxyHandlercreateWorkspaceSandboxTerminalUpgradeHandlerselectedBearerSubprotocolSandboxApiCredentialsgetSandboxApiCredentialsnames or negative assertions, not imported agent-app types.SandboxRuntimeConnectionbearerTokenThe original checkout and
origin/mainwere both9a705616821302f1458b98a98b53d04359888603; a final fetch before push stillshowed the branch based directly on current
origin/main.Test plan
pnpm typecheck— cleanpnpm test— 232 files passed; 3,863 passed / 0 failed / 13 skippedpnpm build— ESM and declaration builds clean; retained manager exportsare present and all removed proxy exports are absent from
dist/sandbox/index.d.tspnpm knip— exit 0 (configuration hints only)pnpm docs:gen— 82 files / 78 entries regeneratedpnpm install --frozen-lockfile --ignore-scripts— cleanrgover all 31 removed export names insrc tests docs— zero matchesgit diff --check— cleanLocal macOS note: the full test command used
/private/tmpplus a test-onlyshell wrapper selecting GNU
base64, avoiding the machine's unrelated.bash_profileerrors and/tmp→/private/tmpcanonicalization mismatch.No source or test behavior was changed for that host setup.