fix(deps): bound the agent-interface peer to versions that actually work - #356
Merged
Conversation
The declared peer was `>=0.36.0` with no ceiling while `src/tools/mcp.ts` imports `agentProfileMcpServerSchema`, `defineAgentProfilePublicConfig`, `defineAgentProfileSecretRef` and `AgentProfileConfigValue` — none of which exist before 0.38.0. A consumer resolving 0.36 or 0.37 gets undefined imports and the pre-0.38 plain-string MCP shape. That is the same failure mode that took a product's chat down for 25 days, still declared as supported. State the range the package actually requires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One line, and it closes a still-armed copy of the outage we already paid for.
agent-app@0.45.1declares:while
src/tools/mcp.ts:37-42importsagentProfileMcpServerSchema,defineAgentProfilePublicConfig,defineAgentProfileSecretRefandAgentProfileConfigValue. None of those exist before 0.38.0 — verified by unpacking the published tarballs: zero occurrences in the 0.36.0 and 0.37.0 dists, first appearance in 0.38.0.So a consumer that resolves 0.36 or 0.37 gets undefined imports and the pre-0.38 plain-string MCP shape. That is precisely the failure that took gtm-agent chat down for 25 days (#703), still declared as a supported configuration by a published package.
Now
>=0.38.0 <0.41.0: the floor is the version that introduced the symbols, the ceiling is the highest line verified against (0.38/0.39/0.40 profile schemas are byte-identical).Expect new peer warnings, and they are true
agent-runtime@0.109.2peersagent-interface >=0.36.0 <0.37.0, so this range and that one cannot both be satisfied. That conflict already exists in reality — gtm-agent only runs because it forces the graph with a pnpm override. Declaring>=0.36.0did not resolve the conflict, it concealed it. A loud, accurate constraint is strictly better than a quiet false one, and agent-runtime widening its peer is already on the release train (agent-dev-container#4524).Rides along with the 0.46.0 publish; merging with
[skip release]so it does not ship ahead of the platform.