Skip to content

Add form_data_skipped_length_ limit check #3653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giorka wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add form_data_skipped_length_ limit check #3653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tdnet/td/net/HttpReader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,9 @@ Result<bool> HttpReader::parse_multipart_form_data(bool can_be_slow) {
LOG(DEBUG) << "Skipping epilogue. Have " << size << " bytes";
content_->advance(size);
form_data_skipped_length_ += size;
// TODO(now): check if form_data_skipped_length is too big
if (form_data_skipped_length_ > MAX_CONTENT_SIZE) {
return Status::Error(413, "Request Entity Too Large: multipart/form-data is too big");
}
return flow_sink_.is_ready();
}
default:
Expand Down